Bug 397381

Summary:	Grammar/spelling error in Configure Konsole, TabBar
Product:	[Applications] konsole	Reporter:	Steven Fisher <tewha>
Component:	general	Assignee:	Konsole Developer <konsole-devel>
Status:	RESOLVED FIXED
Severity:	normal	CC:	egmont
Priority:	NOR
Version:	17.12.3
Target Milestone:	---
Platform:	Other
OS:	Linux
URL:	https://blog.oxforddictionaries.com/2011/03/18/affect-versus-effect/
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Steven Fisher 2018-08-11 19:11:25 UTC

In Settings->Configure Konsole on the TabBar tab there's a spelling error that's unfortunately surrounded by a giant box to highlight it, so it drives me a little bit more crazy each time I see it.

"Starting with Qt 5.9, the next two options will have different affects."

That should be "effects." I'll try to attach a link to Oxford after the initial report.

Comment 1 Steven Fisher 2018-08-11 19:11:35 UTC

https://blog.oxforddictionaries.com/2011/03/18/affect-versus-effect/

Comment 2 Egmont Koblinger 2018-08-12 23:48:49 UTC

Indeed "effect" would be the correct word here.

I'd take a step backwards though and question this entire string.

I have Qt 5.9. Why does it say "will have ...", in future tense?

Why would I care that they used to have different meanings, especially if the UI doesn't state what those meanings were?

Are the next two labels correct now anyway? Or do they correspond to the old behavior? And what's the new behavior, then? This message makes me totally uncertain.

Or is the label correct for both Qt versions, just some little detail changed in the implementation (not _a_ffecting the semantics of the option)?

Why would I care about my Qt version?

Why not just tell me what these options do now, and nothing more? (If technically required, then decide based on a compile-time or run-time check on Qt version).

This thing just looks way too technical, very user unfriendly to me.

Maybe it's just me, more of a GNOME guy than a KDE one, usually following/preferring their UI choices.

Please don't let my rant and overall dislike of this UI block you from quickly applying the one-letter fix first! :)

Comment 3 Kurt Hindenburg 2018-08-14 12:45:27 UTC

Thanks, this was fixed in May 2018 3e42f117 so the new 18.08 and master have the fix.

I realize the text might be confusing.  I wasn't really happy Qt changed the behavior and wanted something to alert users that were confused things had changed.