Bug 397208

Summary: Reference tool not updating correctly when tabbing to full screen. Bad dirty rectangle update.
Product: [Applications] krita Reporter: Douglas <magick.crow>
Component: Tools/Reference ImagesAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: major CC: magick.crow
Priority: NOR    
Version: 4.1.1   
Target Milestone: ---   
Platform: Mint (Ubuntu based)   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: Before tab
Tab error two

Description Douglas 2018-08-06 12:20:48 UTC
Created attachment 114322 [details]
Before tab

Mind KDE fully updated with Nvidia gtx 580 GPU
Krita 4.1.1

When I tab to full window mode a lange chunk of the reference image stays in the wrong place, covering the image I need to work on. Like the dirty rectangle has a one off programming error on its update.

Reproducible. Happens every time (I think).
Comment 1 Douglas 2018-08-06 12:28:14 UTC
I wanted to add an after picture but can't add a second attachment. So here is a link.
http://pasteall.org/pic/f393754a9599c17f3d1047260582f9cc
Comment 2 Douglas 2018-08-06 12:29:39 UTC
Created attachment 114323 [details]
Tab error two

With bug.
Comment 3 joupent 2018-08-10 12:11:15 UTC
Git commit 5018d4733f3cd681a53a1fae2534d83a48f61d36 by Jouni Pentikäinen.
Committed on 09/08/2018 at 13:30.
Pushed by jounip into branch 'master'.

Fix reference image cache update conditions

M  +12   -5    libs/ui/KisReferenceImagesDecoration.cpp

https://commits.kde.org/krita/5018d4733f3cd681a53a1fae2534d83a48f61d36
Comment 4 Halla Rempt 2018-08-11 18:59:49 UTC
Git commit 98a076b9002b1228796062bf90ff1b8c7f5a5a64 by Boudewijn Rempt, on behalf of Jouni Pentikäinen.
Committed on 11/08/2018 at 15:47.
Pushed by rempt into branch 'krita/4.1'.

Fix reference image cache update conditions

M  +12   -5    libs/ui/KisReferenceImagesDecoration.cpp

https://commits.kde.org/krita/98a076b9002b1228796062bf90ff1b8c7f5a5a64