Bug 397149

Summary: ktorrent-5.1.0/libktcore/plugin/pluginmanager.cpp:95: bad if ?
Product: [Applications] ktorrent Reporter: dcb314
Component: generalAssignee: Joris Guisson <joris.guisson>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version First Reported In: 5.1   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description dcb314 2018-08-04 13:13:22 UTC
ktorrent-5.1.0/libktcore/plugin/pluginmanager.cpp:95]: (style) Boolean result is used in bitwise operation. Clarify expression with parentheses.

Source code is

    if (loaded.contains(idx) & !pi.isPluginEnabled())

Maybe better code

    if (loaded.contains(idx) && !pi.isPluginEnabled())
Comment 1 Christoph Feck 2018-08-30 23:45:05 UTC
Git commit 9f681042844454214110a92dd5a2ca75492e914e by Christoph Feck.
Committed on 30/08/2018 at 23:44.
Pushed by cfeck into branch 'master'.

GIT_SILENT Fix conditional expression

M  +1    -1    libktcore/plugin/pluginmanager.cpp

https://commits.kde.org/ktorrent/9f681042844454214110a92dd5a2ca75492e914e
Comment 2 Christoph Feck 2018-08-30 23:56:04 UTC
Thanks, pushed.