| Summary: | libbreezecommon does not install the export header | ||
|---|---|---|---|
| Product: | [Plasma] Breeze | Reporter: | Fabian Vogt <fabian> |
| Component: | general | Assignee: | Plasma Bugs List <plasma-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | vlad.zahorodnii |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed/Implemented In: | ||
| Sentry Crash Report: | |||
|
Description
Fabian Vogt
2018-08-04 11:04:54 UTC
(In reply to Fabian Vogt from comment #0) > A header is generated, but never installed. > > If this is intentional and libbreezecommon is not meant to be used by > something other than breeze, it should not install a .so link. Yes, it's used only by Breeze. (We need to share some code between kstyle and kdecoration) In my defense: libbreezecommon is based on liboxygen, so that's why it is a shared library. I suppose it would be better to turn libbreezecommon into a static library and use it only during build, right? (In reply to Vlad Zagorodniy from comment #1) > (In reply to Fabian Vogt from comment #0) > > A header is generated, but never installed. > > > > If this is intentional and libbreezecommon is not meant to be used by > > something other than breeze, it should not install a .so link. > > Yes, it's used only by Breeze. (We need to share some code between kstyle > and kdecoration) > > In my defense: libbreezecommon is based on liboxygen, so that's why it is a > shared library. > > I suppose it would be better to turn libbreezecommon into a static library > and use it only during build, right? That means the shared parts are contained in the binaries twice, so that would be a steps backwards IMO. If it's not too much, it certainly makes sense though. Fixed with https://cgit.kde.org/breeze.git/commit/?id=763ec6d335417df7985fbbd4ef456287915b4d1d (I added a BUG: in the commit, but arc land reverted that, grmbl) |