Bug 397078

Summary: privateBrowsingIcon icon hardcoded
Product: [Applications] Falkon Reporter: varlesh <varlesh>
Component: generalAssignee: David Rosca <nowrep>
Status: RESOLVED FIXED    
Severity: normal CC: bfeber, matheus4551
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Manjaro   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description varlesh 2018-08-02 05:22:40 UTC
Private Browsing not used icon from current system icon theme.


QIcon IconProvider::newWindowIcon()
{
    return QIcon::fromTheme(QSL("window-new"), QIcon(QSL(":/icons/menu/window-new.svg")));
}

QIcon IconProvider::privateBrowsingIcon()
{
    return QIcon(QSL(":/icons/menu/privatebrowsing.png"));
}


Maybe use icon im-user (it's similar looking with original icon)
Comment 1 matheus4551 2018-11-17 17:19:44 UTC
*** Bug 400261 has been marked as a duplicate of this bug. ***
Comment 2 Christoph Cullmann 2018-12-11 19:55:49 UTC
Git commit f43250f880db29ead8c8eeb511d030f986c7ace8 by Christoph Cullmann, on behalf of Björn Feber.
Committed on 11/12/2018 at 19:55.
Pushed by cullmann into branch 'master'.

Fix hardcoded private browsing icon

Summary:

Fixes the hardcoded private browsing icon in the Falkon application menu.

Test Plan: Open the Falkon application menu on the top right.

Reviewers: #falkon, drosca

Reviewed By: #falkon, drosca

Subscribers: ngraham, drosca, falkon, #falkon

Tags: #falkon

Differential Revision: https://phabricator.kde.org/D17288

M  +1    -1    src/lib/tools/iconprovider.cpp

https://commits.kde.org/falkon/f43250f880db29ead8c8eeb511d030f986c7ace8