Bug 397037

Summary:	Breeze Plasma Theme should include Software Center icons
Product:	[Plasma] plasmashell	Reporter:	trmdi
Component:	Theme - Breeze	Assignee:	visual-design
Status:	RESOLVED INTENTIONAL
Severity:	wishlist	CC:	aleixpol, bugseforuns, kainz.a, kde, kde, nate, plasma-bugs
Priority:	NOR
Version First Reported In:	5.22.4
Target Milestone:	1.0
Platform:	openSUSE
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	Pic1 Pic2

Description trmdi 2018-08-01 03:09:33 UTC

Steps to reproduce:

1. Use the Breeze Dark desktop theme, Breeze icon theme.
2. Change the desktop theme to [Adapta-KDE](https://github.com/PapirusDevelopmentTeam/adapta-kde)
3. Result: the Software Updates icon on the system tray doesn't change to the icon provided by the Adapta desktop theme, it still uses the icon provided by the Breeze icon theme. (Pic1)

Expected result:

It changes to the right icon provided by the Adapta desktop theme.
(If I restart plasmashell, the icon will change to the right one) (Pic2)

Comment 1 trmdi 2018-08-01 03:10:47 UTC

Created attachment 114246 [details]
Pic1

Comment 2 trmdi 2018-08-01 03:11:16 UTC

Created attachment 114247 [details]
Pic2

Comment 3 Kai Uwe Broulik 2018-08-01 08:29:56 UTC

Can confirm

Comment 4 Aleix Pol 2018-08-02 11:05:00 UTC

How is that an issue in Discover?
https://phabricator.kde.org/source/discover/browse/master/notifier/plasmoid/contents/ui/main.qml$28

We're just telling Plasma which icon to use.

Comment 5 trmdi 2018-08-02 14:02:32 UTC

So what product and component should this bug belong to?

Comment 6 David Edmundson 2018-08-05 09:58:20 UTC

Do you know what DiscoverNotifier.iconName evaluates to?

We only connect to the theme changing if we're loading an icon from the Plasma theme, not if it's from the regular icon set.

At a guess the icon is not in breeze, so we don't connect for updates. But it is in Adapta which is why it appears after reload.

Comment 7 Aleix Pol 2018-08-07 13:48:58 UTC

It's: update-* (update-none, update-high, etc).

So it's just not supposed to change?

Comment 8 Kai Uwe Broulik 2018-08-07 14:20:18 UTC

The icon is only in Breeze icons (and Oxygen) but not in the Plasma theme, maybe this causes it not to update.

Comment 9 Aleix Pol 2018-10-11 16:05:28 UTC

Did you change the icon theme as well?

Comment 10 trmdi 2018-10-11 16:18:57 UTC

No, just changed the desktop theme.

Comment 11 Aleix Pol 2018-10-15 14:58:29 UTC

I guess breeze plasma theme should include these icons them, I'm not sure if it's a design decision that these should be part of the plasma theme, I guess it makes sense at least for plasma components.

Comment 12 Nate Graham 2023-08-09 14:59:13 UTC

No need anymore; Plasma theme icons don't exist in Plasma 6, so getting the icon from the icon theme is now intentional.