| Summary: | The "maximise" button is missing in decoration of the geolocation editor window [patch] | ||
|---|---|---|---|
| Product: | [Applications] digikam | Reporter: | Milan Knížek <knizek> |
| Component: | Plugin-Generic-GeolocationEdit | Assignee: | Digikam Developers <digikam-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | metzpinguin |
| Priority: | NOR | ||
| Version: | 6.0.0 | ||
| Target Milestone: | --- | ||
| Platform: | Appimage | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/digikam/62499189cbe39308bff2315a98cfd21f3a7397f5 | Version Fixed In: | 6.0.0 |
| Sentry Crash Report: | |||
| Attachments: | windowFlags.patch | ||
|
Description
Milan Knížek
2018-07-31 04:23:40 UTC
Here under a Plasma desktop are all buttons available. GNOME believes that a dialog window does not require buttons to maximize or minimize. As far as I know, you need to install a tweak program to re-enable these windows buttons. Maik Please read this: http://digikam.1695700.n4.nabble.com/digiKam-users-Problems-opening-image-in-darktable-td4705789.html Maik That guy had a problem with Cinnamon, which may not be the same as standard GNOME. I have gnome-tweaks installed, disabled "attach modal dialogs" (so that the dialog window moves separately from the parent window), enabled Maximise and Minimise buttons for the title bar already. That said, Tweaks do not seem to offer a solution for me. You are right, that GNOME treats Geolocation Editor as a dialog window (in Alt+Tab switcher, I can see both digikam and editor as a single icon). Right-clicking on Editor's title bar shows both Maximise and Minimise greyed out (disabled), double click does not maximise the window. Note that the window has a title bar and the close button. I searched a bit more, but no resolution yet. This one suggests that Mac OS might deal with modal windows similarly like GNOME does: https://musescore.org/en/node/56931 P.S. Re-opening the bug if you do not mind. Created attachment 114257 [details]
windowFlags.patch
I've installed a GNOME3 desktop for testing. Although openSUSE creates a very good basic configuration, I have to say it is not my desktop. But it does not matter. This patch removes the Qt::Dialog flag and replaced it with the Qt::Window flag. Now it is possible to maximize and minimize under GNOME. But we have to test whether it has negative effects in other environments.
Maik
Git commit 62499189cbe39308bff2315a98cfd21f3a7397f5 by Maik Qualmann. Committed on 12/08/2018 at 10:43. Pushed by mqualmann into branch 'master'. replace Qt::Dialog window flag with Qt::Window to enable min/max button under GNOME currently tested for problems under GNOME3, KF5 and Window7/10 BUGS: 397001 FIXED-IN: 6.0.0 https://commits.kde.org/digikam/62499189cbe39308bff2315a98cfd21f3a7397f5 Git commit 62499189cbe39308bff2315a98cfd21f3a7397f5 by Maik Qualmann. Committed on 12/08/2018 at 10:43. Pushed by mqualmann into branch 'master'. replace Qt::Dialog window flag with Qt::Window to enable min/max button under GNOME currently tested for problems under GNOME3, KF5 and Window7/10 FIXED-IN: 6.0.0 M +2 -2 NEWS M +4 -0 core/utilities/advancedrename/advancedrenamedialog.cpp M +4 -0 core/utilities/geolocation/editor/dialog/geolocationedit.cpp M +4 -0 core/utilities/maintenance/maintenancedlg.cpp M +3 -0 core/utilities/mediaserver/dmediaserverdlg.cpp M +3 -0 core/utilities/metadataedit/dialog/metadataedit.cpp M +3 -0 core/utilities/setup/setup.cpp https://commits.kde.org/digikam/62499189cbe39308bff2315a98cfd21f3a7397f5 |