Summary: | Online Banking Behavior Change Since 4.8 | ||
---|---|---|---|
Product: | [Applications] kmymoney | Reporter: | Brendan <KDE> |
Component: | onlinebanking | Assignee: | KMyMoney Devel Mailing List <kmymoney-devel> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | ralf.habacker |
Priority: | NOR | ||
Version: | git (master) | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/kmymoney/4b9cc6a8016ccacf501cf41d8d9978436926e6fa | Version Fixed In: | 5.0.2 |
Sentry Crash Report: | |||
Attachments: |
Summary Window
Statement stats |
Description
Brendan
2018-07-26 17:05:00 UTC
I added https://phabricator.kde.org/D14439 to resolve the problem. Anyone is welcome to test it and leave comments there. Created attachment 114183 [details]
Summary Window
Comment on attachment 114183 [details]
Summary Window
I compiled the master branch with the patch. It did add the summary window at the end of the process.
It did NOT eliminate the 13 popups that I had prior to the summary at the end so this added one more window that I had to close:-(
So I had no new transactions and had to close 14 popup windows instead of 13.
Git commit 66523b3c99812e30816668351504063d6620a9c6 by Thomas Baumgart. Committed on 29/07/2018 at 04:52. Pushed by tbaumgart into branch 'master'. Only show a single summary of statement import Summary: Depending on the number of statements imported via online connects to banks, the sheer number of dialogs popping up is annoying and time consuming. This change reduces this to a single dialog which is also shown if no transaction has been imported at all to notify the termination of the process to the user. Test Plan: I ran updates for single accounts as well as multiple accounts Reviewers: wojnilowicz Reviewed By: wojnilowicz Differential Revision: https://phabricator.kde.org/D14439 M +16 -3 kmymoney/converter/mymoneystatementreader.cpp M +2 -0 kmymoney/converter/mymoneystatementreader.h M +7 -30 kmymoney/kmymoney.cpp M +41 -0 kmymoney/kmymoneyutils.cpp M +4 -0 kmymoney/kmymoneyutils.h M +4 -40 kmymoney/views/kaccountsview.cpp M +44 -0 kmymoney/views/kaccountsview_p.h https://commits.kde.org/kmymoney/66523b3c99812e30816668351504063d6620a9c6 (In reply to Brendan from comment #3) > Comment on attachment 114183 [details] > Summary Window > > I compiled the master branch with the patch. It did add the summary window > at the end of the process. > > It did NOT eliminate the 13 popups that I had prior to the summary at the > end so this added one more window that I had to close:-( Very strange, as the code for the message per account is not present anymore in the source. Can you attach a screenshot of one of those 13 popups? Is this OFX related, as I don't see any popups per account anymore, just the final summary. One difference I see is, that I am using KBanking as the online backend. Created attachment 114203 [details]
Statement stats
I've attached the popup window that I see after each account is downloaded. I removed the account name and balance.
I am using OFX.
Come one Thomas, you fixed this 9 years ago. Don't you remember how you did that:-)
I think it's important to keep in mind that this works just like 4.8 when you compile KMM from the 5.0 branch. If none of my accounts have any new transactions I don't get the summary popup at the end and I don't get the 13 popups along the way. Łukasz Wojniłowicz worked on this and asked me to test it back on May 15, 2018. It took me a while to get to it but it seems to work fine in 5.0.2. Not sure why the changes are not in the master branch but they appear to be in the 5.0 branch. Here is the email response that I received from Łukasz via the kmymoney-devel@kde.org. The subject of this email thread is "Problems Compiling KMM KF5": =========== Łukasz Wojniłowicz <lukasz.wojnilowicz@gmail.com> May 15  to For I tried to bring mentioned feature back. Could you try again and see if it has bettered for you? Cheers Łukasz Dnia piątek, 30 marca 2018 17:50:02 CEST Brendan Coupe pisze: Please disregard most of mt last comment. The 5.0 branch is better than the master branch but it's not the same as 4.8. I switched back to 5.0.2 and did more testing to clarify the differences. In the 5.0 branch I no longer get popup windows for every account. I only get popup windows for the accounts that have new transactions. I do NOT get a summary of the downloaded transactions for the accounts that have new transactions at the end. This means if 3 out of 13 accounts have new transactions I get 3 popup windows and the download stops until I clear each window. If none of the 13 accounts has a new transaction then I don't get any popup windows. In the master branch I get popups for every account and with the patch I also get a summary window at the end. For 13 accounts I get 14 popups regardless of whether any of the accounts have new transactions. The combination of eliminating the remaining popups in the 5.0 branch and adding the summary at the end when there is at least one new transaction like how it works with the patch is what is needed to get back to how 4.8 worked. I'm running that 5.0 branch for now but can easily test changes / patches for either branch. Sorry for the confusion. (In reply to Brendan from comment #7) > Not sure why the changes are not in the master branch but they appear to be > in the 5.0 branch. Probably because branch 5.0 was note merged into master branch. No, because it is OFX specific and needs to be fixed in master. I'll take care of it. BTW, the QIF importer seems to have the same problem. Git commit 4b9cc6a8016ccacf501cf41d8d9978436926e6fa by Thomas Baumgart. Committed on 30/07/2018 at 16:57. Pushed by tbaumgart into branch 'master'. Remove per account statement summary The OFX importer displayed a summary per account which conflicts with the global summary after all accounts have been updated and is very annoying in case you have many accounts. M +2 -20 kmymoney/plugins/ofx/import/ofximporter.cpp https://commits.kde.org/kmymoney/4b9cc6a8016ccacf501cf41d8d9978436926e6fa Way to go Thomas, I'm down to one popup with or without new transactions. Works almost the same as 4.8. In 4.8 there was no summary popup when there were no new transactions. In the master there is a summary screen telling you there are no new transactions. I think I might like it better this way since I wasn't always sure the update was done in 4.8. ... and that is the reason, why I added it saying that nothing has been changed. |