Bug 396828

Summary:	PlasmaComponents3 text field doesn't have the ability to display a clear button
Product:	[Frameworks and Libraries] libplasma	Reporter:	Nate Graham <nate>
Component:	components	Assignee:	Marco Martin <notmart>
Status:	RESOLVED UPSTREAM
Severity:	normal	CC:	kde
Priority:	NOR
Version:	5.48.0
Target Milestone:	---
Platform:	Other
OS:	Linux
See Also:	https://bugs.kde.org/show_bug.cgi?id=396813
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Nate Graham 2018-07-24 21:30:23 UTC

The PC1 version can display a clear button[1], but the PC3 version can't[2]. This makes porting code from PC1 to PC3 non-trivial. We should add support for an inline close button to the PC3 TextField. That way we can switch to PC3 for all our text fields and we won't get bugs like Bug 396813.

[1] https://cgit.kde.org/plasma-framework.git/tree/src/declarativeimports/plasmacomponents/qml/TextField.qml#n115

[2] https://cgit.kde.org/plasma-framework.git/tree/src/declarativeimports/plasmacomponents3/TextField.qml

Comment 1 Nate Graham 2018-07-24 23:07:16 UTC

Submitted a patch: https://phabricator.kde.org/D14345

Comment 2 David Edmundson 2018-08-23 00:20:46 UTC

As discussed on the phab request. 

It's more complex as PC3 are not a subclass, but an implementation of a template we don't want to deviate from.

There's no rush to use PC3, we should try and get our clear/reveal password upstream before forking PC3.