Bug 396824

Summary: Folders are selectable in Synchronizer (and when a folder is selected all its files are selected)
Product: [Applications] krusader Reporter: henr
Component: synchronizeAssignee: Krusader Bugs Distribution List <krusader-bugs-null>
Status: CONFIRMED ---    
Severity: normal CC: krusader-bugs-null, nikita+kde, toni.asensi
Priority: NOR    
Version First Reported In: 2.6.0   
Target Milestone: ---   
Platform: Ubuntu   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: 2 test folders used for Synchronize folders error
Total Commander does not allow selecting folders; that avoids the problem that the bug reporter (and other people) have been finding

Description henr 2018-07-24 18:04:35 UTC
Created attachment 114099 [details]
2 test folders used for Synchronize folders error

OK. This bug is a bit complex (I think):
I have attached 2 folders in a zip file. 
You place 'public_html-1' on the left panel and 'public_html-2' on the right panel.
You synchronize them (Tools -> 'Synchronize folders' (Ctrl+Y)) with 'Recurse subfolders' and 'Ignore Date' selected (the rest unselected). 
Using 'Show options' to only view "<-" you see 7 (blue) files. 
Using 'Show options' to only view "not equal" you see 26 (red) files, 2 of them in a sub-folder.
You now select all of them, mouse right-click opens a menu, choose "Copy from right to left".
Now the list is empty, but no copy operation has occurred, so I ASSUME the intended operation is to move the files to the (blue) "<-"-category. But when you switch back to viewing that category it now contains 54 files and not 7+26=33!
Many (maybe all?) of the extra files are in the sub-folder 'PlanetX'.

PS: A similar error occurs using "Copy from left to right".
Comment 1 Toni Asensi Esteve 2018-08-17 12:32:17 UTC
Hello!

> You now select all of them, mouse right-click opens a menu, choose "Copy from
> right to left".
> Now the list is empty, but no copy operation has occurred, so I ASSUME the
> intended operation is to move the files to the (blue) "<-"-category.

I also think that: that set of files is no longer seen because the user stipulated that he *only* wanted to see the "not equal" files, but later the set of files is in the "<- (copy from right to left)" category.

> But when
> you switch back to viewing that category it now contains 54 files and not
> 7+26=33!
> Many (maybe all?) of the extra files are in the sub-folder 'PlanetX'.

I think that you had the 'PlanetX' sub-folder selected when you choose "copy from right to left" and therefore: the whole folder was selected to be copied "from right to left".

If (for example using Ctrl+click) I unselect the 'PlanetX' sub-folder when I choose the files that must be copied "copy from right to left": then at the end only 33 files are shown (which is correct, as you wrote).

The bug would be that, when selecting a group of items, a folder is selected easily (and then all its files are selected).             

I've tried Double Commander and does not allow selecting folders, Total Commander neither does (I'll attach a screenshot)
Comment 2 Toni Asensi Esteve 2018-08-17 12:35:33 UTC
Created attachment 114463 [details]
Total Commander does not allow selecting folders; that avoids the problem that the bug reporter (and other people) have been finding
Comment 3 Toni Asensi Esteve 2018-08-17 12:41:40 UTC
> Total Commander does not allow selecting folders; that avoids the 
> problem that the bug reporter (and other people) have been finding
In the screenshot the folder "PlanetX" is shown like a gray bar, is not selectable even if the user utilizes the mouse to select a range of files (to select a range of files, you can click the first file, then press the Shift key while clicking the last file in the range).
Comment 4 Nikita Melnichenko 2018-08-24 04:47:59 UTC
Can you re-title it according to your findings?