Bug 396792

Summary:	Grouping of tasks ignores "only show tasks from current desktop"
Product:	[Plasma] plasmashell	Reporter:	Leszek Lesner <leszek.lesner>
Component:	Task Manager and Icons-Only Task Manager	Assignee:	Eike Hein <hein>
Status:	RESOLVED FIXED
Severity:	normal	CC:	nate, plasma-bugs
Priority:	NOR
Version:	5.12.5
Target Milestone:	1.0
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/plasma-workspace/c8358c203f118f2559651c0a48d12a825ffee7da	Version Fixed In:	5.14.0
Attachments:	Settings for the taskmanager that causes the issue

Description Leszek Lesner 2018-07-23 10:57:50 UTC

Grouping of tasks in the panel seems to be always active and ignoring "only show tasks from current desktop". 

To reproduce: 
1. Activate "only show tasks from current desktop" + manual sorting of tasks and leave grouping of tasks turned on "by application name".
2. Go to a clean virtual desktop and open konsole
3. Go to another clean virtual desktop and open a bunch of application windows (see how the tasks open right next to the previous application)
4. Try opening up a new konsole window on that virtual desktop and see how its tasks is shown far left at position 1 of the tasklist

How it should behave:
In step 4. it should create the new konsole task like all the other apps right to the last opened one (or if another konsole task is opened right next to it to follow the grouping on that particular virtual desktop)

Comment 1 Leszek Lesner 2018-07-23 11:15:34 UTC

Created attachment 114083 [details]
Settings for the taskmanager that causes the issue

I attached an image with the settings I set for the task manager. 
Also noticed that checking "Keep launchers separate" seems to create the expected behavior.

Comment 2 Eike Hein 2018-07-26 06:19:55 UTC

"Keep launchers seperate" is the default btw

Comment 3 Eike Hein 2018-07-26 06:20:31 UTC

Do you have Konsole pinned to your panel in this example?

Comment 4 Eike Hein 2018-07-26 07:00:05 UTC

Nvm - was able to reproduce.

Patch: https://phabricator.kde.org/D14392

Comment 5 Eike Hein 2018-09-10 11:15:22 UTC

Git commit c8358c203f118f2559651c0a48d12a825ffee7da by Eike Hein.
Committed on 10/09/2018 at 11:14.
Pushed by hein into branch 'master'.

Don't consider filtered out tasks siblings when sorting in new tasks

Summary: BUG:396792

Reviewers: davidedmundson, broulik

Reviewed By: broulik

Subscribers: broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D14392

M  +9    -2    libtaskmanager/tasksmodel.cpp

https://commits.kde.org/plasma-workspace/c8358c203f118f2559651c0a48d12a825ffee7da