| Summary: | CSV: ordering of buttons when finishing wizard | ||
|---|---|---|---|
| Product: | [Applications] kmymoney | Reporter: | Martin Steigerwald <Martin> |
| Component: | importer | Assignee: | KMyMoney Devel Mailing List <kmymoney-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | ||
| Priority: | NOR | ||
| Version: | 5.0.1 | ||
| Target Milestone: | --- | ||
| Platform: | Debian unstable | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/kmymoney/033b747aa5184b29dd846d1573ce87a0cd6bffab | Version Fixed In: | 5.0.2 |
| Sentry Crash Report: | |||
| Attachments: | screenshot showing the button order when finishing the importer (german text) | ||
Git commit 033b747aa5184b29dd846d1573ce87a0cd6bffab by Thomas Baumgart. Committed on 29/07/2018 at 16:58. Pushed by tbaumgart into branch 'master'. Improve CSV importer Summary: - Make the CSV importer to run as a modal dialog of the application as other importers do. This avoids a whole bunch of problems. - Combine the Finish and Import button into a single "Import CSV" button on the last page of the wizard. - In case 'Skip setup' is marked on the first page, the wizard stops on the last page and does not automatically start importing. Test Plan: Tested single file import and web-connect import Reviewers: wojnilowicz Reviewed By: wojnilowicz Differential Revision: https://phabricator.kde.org/D14459 M +1 -1 kmymoney/kmymoney.cpp M +18 -34 kmymoney/plugins/csv/import/csvimporter.cpp M +1 -11 kmymoney/plugins/csv/import/csvimporter.h M +37 -37 kmymoney/plugins/csv/import/csvwizard.cpp M +6 -7 kmymoney/plugins/csv/import/csvwizard.h https://commits.kde.org/kmymoney/033b747aa5184b29dd846d1573ce87a0cd6bffab |
Created attachment 114068 [details] screenshot showing the button order when finishing the importer (german text) Usually when I run the CSV import wizard, then I like to import an CSV file. I found that I clicked on "Finish" (german "Abschließen") instead of "Import CSV file" (german "CSV-Datei importieren") due to the expectation that the most usual action would be next to the cancel button.