Bug 396753

Summary: Show a [Super] badge for Application Menu if the user has set the [Super] key to activate it
Product: [Unmaintained] lattedock Reporter: trmdi
Component: applicationAssignee: Michail Vourlakos <mvourlakos>
Status: RESOLVED FIXED    
Severity: wishlist    
Priority: NOR    
Version First Reported In: git (master)   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description trmdi 2018-07-22 13:26:04 UTC
If the user has set the Winkey to activate the application menu, Latte should ignore the unified key for it, and show the [Winkey] badge instead.

Something like this: say Application Menu is the first item.

+Current badges and hotkeys : [1] [2] [3] [4]

+Suggest: [Winkey] [1] [2] [3] ...
Comment 1 Michail Vourlakos 2018-07-22 17:52:04 UTC
As mentioned earlier,

Currently there is no winkey badge and the codepaths are different, Meta is called from KWin and applets/tasks activation from KGlobalAccel.

Even if we want to just a badge to be shown when Meta+' is triggered then other cases should also be considered.

What happens when app launcher is in different dock?
What happens if the app launcher is between other applets?

Only I can think of is to show a Meta badge (https://www.utf8icons.com/character_image/8984-place-of-interest-sign.png , unicode character \u2318) for application launcher without showing its unified shortcut at all cases and at the same time provide the unified Global Shortcuts flag...

This way the following can be supported,

1-2-⌘-4-5-6-7

⌘-1-2-3-4-5-6-7-8 with no unified shortcuts

⌘-2-3-4-5-6-7-8 with unified shortcuts

1-2-3-4-5-6-7-8 and ⌘ in different dock


The unified global shortcuts can be added at Latte settings Window also but only for Master branch, v0.8 is in string freeze
Comment 2 Michail Vourlakos 2018-07-23 12:29:15 UTC
(In reply to trmdi from comment #0)
> 

I am planning to support this in master and add also two options in Latte Preferences. One for unifiedGlobalShortcuts and one for the Meta key...

Will you be able to test the implementation after I commit them to master?
Comment 3 trmdi 2018-07-23 12:41:46 UTC
(In reply to Michail Vourlakos from comment #2)
> (In reply to trmdi from comment #0)
> > 
> 
> I am planning to support this in master and add also two options in Latte
> Preferences. One for unifiedGlobalShortcuts and one for the Meta key...
> 
> Will you be able to test the implementation after I commit them to master?

Sure!
Comment 4 Michail Vourlakos 2018-07-23 16:01:59 UTC
Git commit 6708510213aba9d4b17da4bc338fc1e962f14d40 by Michail Vourlakos.
Committed on 23/07/2018 at 14:00.
Pushed by mvourlakos into branch 'master'.

support a meta badge visual from global shortcuts

--when an application launcher exists, Latte can show
a "Meta" badge for that applet instead of the global
shortcut action number. With this patch we take also
into account when the assigned application launcher is
in different dock/panel and show it accordingly

M  +224  -101  app/globalshortcuts.cpp
M  +16   -8    app/globalshortcuts.h
M  +13   -0    app/layoutmanager.cpp
M  +1    -0    app/layoutmanager.h
M  +23   -0    app/universalsettings.cpp
M  +7    -0    app/universalsettings.h
M  +15   -5    containment/package/contents/ui/applet/AppletItemWrapper.qml
M  +8    -2    containment/package/contents/ui/main.qml

https://commits.kde.org/latte-dock/6708510213aba9d4b17da4bc338fc1e962f14d40