Summary: | Wrong dates for equinoxes and solstices | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-kholidays | Reporter: | Karl Ove Hufthammer <karl> |
Component: | general | Assignee: | kdepim bugs <kdepim-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | dvratil, winter |
Priority: | NOR | ||
Version: | 5.47.0 | ||
Target Milestone: | --- | ||
Platform: | Other | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/kholidays/55e1d14fe900a5ac1acd3a76dfa51f8ccfa67b21 | Version Fixed In: | 5.50 |
Description
Karl Ove Hufthammer
2018-07-22 11:38:57 UTC
oh geez... I just assumed astroseasons was fully operational. I started writing it so many years ago. I didn't even look at the code. I never finished it. I suppose we need to revert f30afcb74a815e5d554f61555f2dd6f1f67445b7 and maybe others Git commit 55e1d14fe900a5ac1acd3a76dfa51f8ccfa67b21 by Daniel Vrátil. Committed on 27/08/2018 at 18:42. Pushed by dvratil into branch 'master'. Implement proper equinox and solstice calculation algorithm Summary: Use algorithm described in Jean Meeus' Astronomical Algorithms book to calculate exact date on which a season occurs in given year. FIXED-IN:5.50 Reviewers: winterz Reviewed By: winterz Subscribers: kde-pim Tags: #kde_pim Differential Revision: https://phabricator.kde.org/D15092 M +34 -15 autotests/testseasons.cpp M +2 -2 autotests/testseasons.h M +112 -18 src/astroseasons.cpp M +10 -0 src/astroseasons.h https://commits.kde.org/kholidays/55e1d14fe900a5ac1acd3a76dfa51f8ccfa67b21 |