Bug 396626

Summary:	help-about in both preferences and actions
Product:	[Plasma] Breeze	Reporter:	Marco Martin <notmart>
Component:	Icons	Assignee:	visual-bugs-null
Status:	RESOLVED FIXED
Severity:	normal	CC:	kainz.a, nate, vkrause
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/breeze-icons/dc0a9ef4d183681f88e1e79f4bc75d6f2e2253c3	Version Fixed/Implemented In:	5.64
Sentry Crash Report:

Description Marco Martin 2018-07-18 11:17:30 UTC

breeze icons have help-about in both preferences/ and actions/ .. this is kindof a problem as all the code around assumes names are globally unique for icons.
QIcon::fromTheme will return the first one of those with an indefinite behavior and Kirigami has a broken CMake macro because of it.
One of them (probably the one under preferences) should be removed.
If they really need to be different,  the one in preferences should be renamed to something unique

Comment 1 Aleix Pol 2018-07-23 14:29:51 UTC

Git commit a492ecde646702881c1f8641d2d83ebabd7b114e by Aleix Pol.
Committed on 23/07/2018 at 14:28.
Pushed by apol into branch 'master'.

kirigami_package_breeze_icons: don't treat lists as elements

Summary:
GLOB_RECURSE will give us a list, treat it as such.
Also when the list has more than just one item, pick the first as the best
candidate.
Some cases like help-about has more than one and it fails currently.

Reviewers: mart, vkrause, andreaska

Reviewed By: mart

Subscribers: plasma-devel

Tags: #kirigami

Differential Revision: https://phabricator.kde.org/D14299

M  +9    -4    KF5Kirigami2Macros.cmake

https://commits.kde.org/kirigami/a492ecde646702881c1f8641d2d83ebabd7b114e

Comment 2 Nate Graham 2019-10-31 00:02:35 UTC

Will fix.

Comment 3 Nate Graham 2019-10-31 18:55:42 UTC

Git commit dc0a9ef4d183681f88e1e79f4bc75d6f2e2253c3 by Nate Graham.
Committed on 31/10/2019 at 18:54.
Pushed by ngraham into branch 'master'.

Move colorful 32px help-about icon into actions
Otherwise there are duplicate icons with the same name and size but
different appearances, which is no bueno
FIXED-IN: 5.64

M  +27   -17   icons-dark/actions/32/help-about.svg
D  +0    -28   icons-dark/preferences/32/help-about.svg
M  +27   -17   icons/actions/32/help-about.svg
D  +0    -28   icons/preferences/32/help-about.svg

https://commits.kde.org/breeze-icons/dc0a9ef4d183681f88e1e79f4bc75d6f2e2253c3