Bug 396594

Summary: Krita 4.1.1 fails to build with Qt < 5.9.0
Product: [Applications] krita Reporter: Wolfgang Bauer <wbauer1>
Component: GeneralAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version First Reported In: git master (please specify the git hash!)   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description Wolfgang Bauer 2018-07-17 08:34:19 UTC
compiler error:
/home/abuild/rpmbuild/BUILD/krita-4.1.1/krita/main.cc:36:35: fatal error: QOperatingSystemVersion: No such file or directory
 #include <QOperatingSystemVersion>
                                   ^
compilation terminated.

This is obviously introduced by https://cgit.kde.org/krita.git/commit/krita/main.cc?h=krita/4.1&id=a05bb4b7df398882fa9c134bdb5b8284e799054f , the "#include <QOperatingSystemVersion>" should be guarded by a version check as well.
Comment 1 Halla Rempt 2018-07-17 08:36:49 UTC
Git commit 55fcc4d4843c47802ad7f42cbc7a4b6c16fe6d23 by Boudewijn Rempt.
Committed on 17/07/2018 at 08:36.
Pushed by rempt into branch 'master'.

Add #if QT_VERSION >= 0x050900 to the include for QOperatingSystemVersion

M  +2    -0    krita/main.cc

https://commits.kde.org/krita/55fcc4d4843c47802ad7f42cbc7a4b6c16fe6d23
Comment 2 Halla Rempt 2018-07-17 13:48:45 UTC
Git commit f6b193a87ad6712d148704a0c2dfaf237bd8f87b by Boudewijn Rempt.
Committed on 17/07/2018 at 08:36.
Pushed by rempt into branch 'rempt/T379-resource-management'.

Add #if QT_VERSION >= 0x050900 to the include for QOperatingSystemVersion

M  +2    -0    krita/main.cc

https://commits.kde.org/krita/f6b193a87ad6712d148704a0c2dfaf237bd8f87b
Comment 3 Andrey 2018-07-19 11:29:25 UTC
Git commit b5eab7703bd187825112b3cc8f9d9bce59c9f5f0 by Andrey Kamakin, on behalf of Boudewijn Rempt.
Committed on 19/07/2018 at 11:14.
Pushed by akamakin into branch 'akamakin/T8628-multithreading-optimization'.

Add #if QT_VERSION >= 0x050900 to the include for QOperatingSystemVersion

M  +2    -0    krita/main.cc

https://commits.kde.org/krita/b5eab7703bd187825112b3cc8f9d9bce59c9f5f0
Comment 4 Halla Rempt 2018-07-23 09:34:24 UTC
Git commit cbfc39c8e130eb5ed5855cda579e58c355e3133c by Boudewijn Rempt.
Committed on 23/07/2018 at 09:33.
Pushed by rempt into branch 'krita/4.1'.

Add #if QT_VERSION >= 0x050900 to the include for QOperatingSystemVersion

M  +2    -0    krita/main.cc

https://commits.kde.org/krita/cbfc39c8e130eb5ed5855cda579e58c355e3133c