| Summary: | Kate crashed under Wayland | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] kwayland | Reporter: | John Apple II <jappleii> |
| Component: | client | Assignee: | Martin Flöser <mgraesslin> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | crash | CC: | Andreas, bilal.elmas, christoph, kde, meven29, mgraesslin, notuxius, rorus |
| Priority: | NOR | Keywords: | drkonqi, wayland |
| Version: | 5.49.0 | ||
| Target Milestone: | --- | ||
| Platform: | Fedora RPMs | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: | attachment-28379-0.html | ||
|
Description
John Apple II
2018-07-17 07:43:52 UTC
Possibly related bugs - https://bugs.kde.org/show_bug.cgi?id=396239 https://bugs.kde.org/show_bug.cgi?id=392401 What could make KF5WaylandClient stuff run in a non-gui thread? PlasmaWindowManagement interface uses QtConcurrent, but nothing else. Kate shouldn't use that as it's not intended for applications like Kate. I am not aware that we use such a thing (and even less in a thread). Is there anything specific to search for if such code slipped in? Reassigning to kwayland. In plasmawindowmanagement.cpp, QtConcurrent is indeed used to read QIcon. The QIcon class cannot be used outside the main thread. While most icons just reference a theme using a name, there exists icons that are contructed from QPixmap. Serializing it causes the error here. A simple workaround is to check if the QIcon has name using QIcon::name(), and if not, refuse to serialize it. The proper fix would be to convert between QPixmap and QImage data before going to the "wire". The client could then, after receiving the QImage data, construct a QIcon from it in the main thread. *** Bug 397533 has been marked as a duplicate of this bug. *** *** Bug 393569 has been marked as a duplicate of this bug. *** *** Bug 386089 has been marked as a duplicate of this bug. *** *** Bug 402133 has been marked as a duplicate of this bug. *** *** Bug 401710 has been marked as a duplicate of this bug. *** Is this still reproducible ? It is not (or at least I never had this crash) on my Plasma 5.17, Qt 5.12 system. Those bugs were reported a few versions ago, Wayland support in Plasma and Qt has improved since. (In reply to Méven Car from comment #12) > Is this still reproducible ? > It is not (or at least I never had this crash) on my Plasma 5.17, Qt 5.12 > system. > > Those bugs were reported a few versions ago, Wayland support in Plasma and > Qt has improved since. I've switched back to using KDE under X for about a year now - there are a couple of critical features for me that Wayland hasn't supported, yet, and this hasn't happened to me since. (In reply to John Apple II from comment #13) > I've switched back to using KDE under X for about a year now - there are a > couple of critical features for me that Wayland hasn't supported, yet, and > this hasn't happened to me since. Do you mean it hasn't happened in Wayland ? I will probably close this if you don't or can't or won't test and reproduce it. Created attachment 123270 [details] attachment-28379-0.html On Thu, 17 Oct 2019, 19:53 Méven Car, <bugzilla_noreply@kde.org> wrote: > https://bugs.kde.org/show_bug.cgi?id=396591 > > --- Comment #14 from Méven Car <meven29@gmail.com> --- > (In reply to John Apple II from comment #13) > > I've switched back to using KDE under X for about a year now - there are > a > > couple of critical features for me that Wayland hasn't supported, yet, > and > > this hasn't happened to me since. > > Do you mean it hasn't happened in Wayland ? > > I will probably close this if you don't or can't or won't test and > reproduce > it. > > -- > You are receiving this mail because: > You reported the bug. Sorry, accidentally replied to the last message via e-mail. No, currently I don't have a way to test this anymore to reproduce. Kate hasn't crashed on me in a very long time, and I've run that scenario that caused it multiple times under X. Close it - if I can get it to occur again, I'll re-raise the bug. Could not reproduce anymore. I don't know why Kate was ever going in this code. That was something else that was clearly wrong. As for QIcon and threads, the retrieval of an icon is fine. We get it in a thread, no-one else can be using it at the same time. The datastream serialisation doesn't use the name so we avoid the QIcon::fromTheme issue. When we're writing we copy the icon into the new thread before starting. wayland supports threaded pixmaps. I'm not sure I see the issue. Dear Bug Submitter, This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging If you have already provided the requested information, please mark the bug as REPORTED so that the KDE team knows that the bug is ready to be confirmed. Thank you for helping us make KDE software even better for everyone! This bug has been in NEEDSINFO status with no change for at least 30 days. The bug is now closed as RESOLVED > WORKSFORME due to lack of needed information. For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging Thank you for helping us make KDE software even better for everyone! |