Bug 396531

Summary: No speed-dial after upgrade to KF5.48
Product: [Applications] Falkon Reporter: Pawel <pavbaranov>
Component: generalAssignee: David Rosca <nowrep>
Status: RESOLVED DUPLICATE    
Severity: normal CC: rullger
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: speeddial json exception

Description Pawel 2018-07-15 11:55:24 UTC
After upgrading KF5 to 5.48 speed-dial no longer works (only empty screen, any content cannot be seen, and any cannot be add).
Comment 1 David Rosca 2018-07-15 12:01:23 UTC
Can you please send terminal output and also are there any errors in web inspector when trying to load speed dial page?
Comment 2 Pawel 2018-07-15 15:18:11 UTC
Any useful terminal output:
[code]LC_ALL=C falkon
Falkon: 2 extensions loaded[/code]
Web inspector? I cannot load because it very long.
Comment 3 David Rosca 2018-07-15 15:51:29 UTC
Press F12 and copy log in "Console" tab.
Comment 4 Pawel 2018-07-15 17:26:35 UTC
This one?:
[code]falkon:speeddial:1 Uncaught SyntaxError: Unexpected token P in JSON at position 4146138
    at JSON.parse (<anonymous>)
    at init (VM31 userscript:_falkon_speeddial:453)
    at VM31 userscript:_falkon_speeddial:508
    at VM31 userscript:_falkon_speeddial:513[/code]
Comment 5 Richard Ullger 2018-07-16 18:24:40 UTC
I'm using Arch and don't see this behaviour. Speeddial working as it should. Web inspector console is blank.

KF5 5.48.0-1
Falkon 3.0.1-4
Comment 6 Pawel 2018-07-16 20:15:27 UTC
Strange... I test it with Falkon 3.0.1-4 and with my build of falkon-git (rebuild against KF5.48 too). With KF5.47 speed dial works, after upgrade - not.
Comment 7 David Rosca 2018-07-17 09:24:39 UTC
Do you use different Qt version for your build?
Comment 8 Richard Ullger 2018-07-17 09:35:49 UTC
I'm using all current Arch repo packages.

Qt 5.11.1
Comment 9 Pawel 2018-07-17 15:22:20 UTC
(In reply to David Rosca from comment #7)
> Do you use different Qt version for your build?

No. My system:
Qt 5.11.1 from official Arch's repository
KF 5.48 from official Arch's repository and it should be build against of Qt 5.11.1 
Falkon - my version is build from GIT on Qt 5.11.1 and KF 5.48 (I rebuild it after announcing this bug, too).
I try falkon from Arch's repository, but speed dial doesn't works on it, also.
Before upgrade to KF5.48RC (it was my build from source) speed dial works perfectly. After upgrade to KF5.48RC and later to KF5.48 (from repository) it stops working anymore.

I'll try falkon from repository on "clear" new user and/or deleter falkonrc and cache.
Comment 10 David Rosca 2018-07-17 16:36:30 UTC
Created attachment 113988 [details]
speeddial json exception

Can you please try with this patch?
Comment 11 Pawel 2018-07-17 17:11:04 UTC
(In reply to David Rosca from comment #10)
> Created attachment 113988 [details]
> speeddial json exception
> 
> Can you please try with this patch?

Yes, of course, I've just applied it, but...
I remove all falkon* and qupzilla* cache and config files and now new added urls to speeddial works.
Comment 12 David Rosca 2018-12-24 20:00:17 UTC

*** This bug has been marked as a duplicate of bug 402024 ***