Bug 396363

Summary: Text tool SIGABRT when inserting a tab followed by multiple letters
Product: [Applications] krita Reporter: Liz <lizsouto1983>
Component: Tool/TextAssignee: vanyossi <ghevan>
Status: RESOLVED FIXED    
Severity: crash CC: freebox64, ghevan, halla
Priority: NOR    
Version: 4.1.0 beta   
Target Milestone: ---   
Platform: Appimage   
OS: Linux   
Latest Commit: Version Fixed In:
Attachments: Screen message when bug happens
Video
GDB (but it's from an appimage...)
(Video example 2)
PrintScreen of the Text tool bug

Description Liz 2018-07-10 12:41:37 UTC
Created attachment 113863 [details]
Screen message when bug happens

Multiple crash and auto-closing Krita window with message in the screen (see screenshot).
Happened multiple times when writing text with broken lines (enter key at the end of each line).
Comment 1 Halla Rempt 2018-07-10 12:43:26 UTC
I'm not sure it has anything to do with the number of lines, and I haven't seen this message myself yet. Does Krita stop if you press ignore?
Comment 2 Liz 2018-07-10 13:17:52 UTC
if you press ignore,it keeps with the message four or five times then krita shuts down. Pressing abort, everything closes at once and i lose everything since last saving.
Comment 3 mvowada 2018-09-07 10:31:11 UTC
Created attachment 114821 [details]
Video

Hi. I think I'm able to reproduce it (see video). Steps:

1. while editing text insert a tab and multiple letters
2. save the text

Actual Results: SIGABRT signal (aborting and closing the Edit text window makes Krita unresponsive)
Expected: just save the text
Comment 4 mvowada 2018-09-07 10:37:37 UTC
(Checked using Krita Appimage 4.2.0-pre-alpha (git 65a1598) - Ubuntu 14.04, Unity)
Comment 5 mvowada 2018-09-07 10:44:50 UTC
(I've updated the title... Please, let me know if you think it doesn't reflect your original issue, thanks!)
Comment 6 mvowada 2018-09-07 10:50:49 UTC
Created attachment 114822 [details]
GDB (but it's from an appimage...)
Comment 7 mvowada 2018-10-18 21:59:47 UTC
Created attachment 115740 [details]
(Video example 2)

I've uploade a new video example. To reproduce, open the text editor and type:

    letter + tab + letter
    
RESULTS: when saving, the second letter won't appear on canvas.

    letter + tab + letter + tab
    -OR-
    tab + letter +letter
    
RESULTS: when saving one or multiple asserts pop up.

(Tested with Krita 4.2.0-pre-alpha (git a2ae7f3)
Comment 8 Liz 2019-04-13 08:43:52 UTC
Created attachment 119393 [details]
PrintScreen of the Text tool bug

Video containing bug: https://youtu.be/_ZRil6XU4RM

I am sending this video on April 13th 2019, with Krita 4.1.7 appimage on Linux Mint LTS with the same bug. Just to let you guys know.
Comment 9 vanyossi 2019-05-03 18:00:41 UTC
Git commit ba110613f4199662111c804538097379260082fc by Ivan Yossi.
Committed on 03/05/2019 at 19:21.
Pushed by ivany into branch 'master'.

Fix: Missing rendered text when using tabs.

We try to guess columns used from string lenght. Because
tab uses more than one column, we incorrectly detected
less glyphs in text, leading to lost characters on screen.

M  +36   -0    libs/flake/tests/TestSvgText.cpp
M  +1    -0    libs/flake/tests/TestSvgText.h
A  +-    --    libs/flake/tests/data/svg_render/load_text_tab_spacing.png
M  +9    -1    libs/flake/text/KoSvgTextShape.cpp

https://invent.kde.org/kde/krita/commit/ba110613f4199662111c804538097379260082fc