| Summary: | [PATCH] Provide screenshot in Appstream metadata | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] kio-gdrive | Reporter: | Nicholas D Steeves <nsteeves> |
| Component: | general | Assignee: | Elvis Angelaccio <elvis.angelaccio> |
| Status: | RESOLVED FIXED | ||
| Severity: | minor | CC: | nate |
| Priority: | NOR | ||
| Version First Reported In: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Debian unstable | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/kio-gdrive/a5979f4748eb1ee4b97cf9b90a33caf14c3eb32e | Version Fixed/Implemented In: | 1.3.0 |
| Sentry Crash Report: | |||
| Attachments: | Patch that adds screenshot section to Appstream metadata | ||
|
Description
Nicholas D Steeves
2018-07-06 18:49:49 UTC
(In reply to Nicholas D Steeves from comment #0) > Created attachment 113811 [details] > Patch that adds screenshot section to Appstream metadata Thanks! Do you mind re-uploading the patch at phabricator.kde.org? See https://community.kde.org/Infrastructure/Phabricator for instructions. > > Hi, > > I followed: > https://community.kde.org/Guidelines_and_HOWTOs/AppStream > and > https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag- > screenshots > > Is the reason there isn't a https://cdn.kde.org/screenshots/ entry for KIO > GDrive because it's part of Extras? No, it's just that no one did the work so far :) Do you need a hand submitting the patch, Nicholas? I'd be happy to help you out. Hi Elvis and Nate, Well, it seems my email address was already registered with KDE Identity (strange), so I'm unable to use it to apply for an account with Phabricator. I send an email to sysadmin@kde.org because I don't have a record (nor memory) of ever signing up for this account. While waiting to hear back from sysadmin, would providing a git remote be sufficiently convenient to merge this trivial patch? I prefer to avoid web things when possible. Cheers, Nicholas Hi Elvis and Nate, Ben, the/a KDE sysadmin replied to my inquiry and we sorted things out. Patch submitted for review on Phabricator. Nate, I would have also added you for review of the patch, but it seems you were not available in the query reviewers box. Cheers, Nicholas Can you paste the link to the patch here? I'm @ngraham on Phabricator. (In reply to Nate Graham from comment #5) > Can you paste the link to the patch here? I'm @ngraham on Phabricator. https://phabricator.kde.org/D14119 Git commit a5979f4748eb1ee4b97cf9b90a33caf14c3eb32e by Elvis Angelaccio, on behalf of Nicholas D Steeves. Committed on 02/09/2018 at 14:47. Pushed by elvisangelaccio into branch 'master'. Add screenshot to gdrive.appdata.xml. FIXED-IN: 1.3.0 Reviewers: elvisangelaccio, pino, ngraham Reviewed By: elvisangelaccio, ngraham Subscribers: anthonyfieroni, cfeck, ngraham, pino Differential Revision: https://phabricator.kde.org/D14119 M +6 -0 desktop/org.kde.kio_gdrive.appdata.xml https://commits.kde.org/kio-gdrive/a5979f4748eb1ee4b97cf9b90a33caf14c3eb32e |