Bug 396144

Summary: [Wish/Bug] Picking colors from Reference Image (Color Picker tool doesn't work; enable option to pick by just clicking)
Product: [Applications] krita Reporter: Tiar <tamtamy.tymona>
Component: UsabilityAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: halla, joupent
Priority: NOR    
Version: 4.1.0   
Target Milestone: ---   
Platform: Other   
OS: Microsoft Windows   
Latest Commit: Version Fixed In:

Description Tiar 2018-07-03 22:56:28 UTC
If you select the color picker from the toolbar, it doesn't pick colors from Reference Image the way that quick color picker (ctrl + click) does. Also it would be nice to have an option to pick colors from Reference Image without holding ctrl (but as an option).

Reproducible: Always.

Steps to reproduce:

A. Color Picker Tool:

1. Open new document, color it to two colors (X and Y), add a reference photo.
1. Choose Color Picker Tool.
2. Click on Reference Image (repeatedly, on top of both colors).

Actual results:
3a. When on color X, color picker prints out (in Tool Options docker) that specific color and updates current color to it. When on the other color (Y), it prints out different values and updates current color to it. When on various parts on Reference Image, it prints out different values (different than X and Y and usually picked colors differs from themselves), but the current color remains not updated.

Expected results:
3b. Current color is updated to the new value picked from Reference Image.

B. Picking by just clicking (the way it worked in Reference Docker):

1. Open new document, add a reference photo.
2. Click on reference photo.

Actual results:
3a. Painting behind the Reference Image.

Expected results:
3b. Option to pick colors from Ref. Image with just clicking; when selected/checked, after clicking it should update the current color to the color picked from the Reference Image.

Relevant posts from reddit: 
A, B - https://www.reddit.com/r/krita/comments/8u83le/krita_410_released/e1dcnq1/
A - https://www.reddit.com/r/krita/comments/8vp7p2/color_selector_tool_not_working_on_the_reference/

A is very much needed, B is (for me) a nice addition, but should be optional because this functionality might be confusing.
Comment 1 joupent 2018-07-04 13:07:27 UTC
Git commit c16dbaeeb54d1811e81ffe82e22ebcb89c9859c9 by Jouni Pentikäinen.
Committed on 04/07/2018 at 12:45.
Pushed by jounip into branch 'master'.

Fix color picker tool not working on reference images

M  +26   -18   plugins/tools/basictools/kis_tool_colorpicker.cc
M  +1    -1    plugins/tools/basictools/kis_tool_colorpicker.h

https://commits.kde.org/krita/c16dbaeeb54d1811e81ffe82e22ebcb89c9859c9
Comment 2 Halla Rempt 2018-07-09 14:54:03 UTC
Git commit 82073ab719a2e8e90117e0632ad309f77ed18197 by Boudewijn Rempt, on behalf of Jouni Pentikäinen.
Committed on 09/07/2018 at 14:39.
Pushed by rempt into branch 'krita/4.1'.

Fix color picker tool not working on reference images

M  +26   -18   plugins/tools/basictools/kis_tool_colorpicker.cc
M  +1    -1    plugins/tools/basictools/kis_tool_colorpicker.h

https://commits.kde.org/krita/82073ab719a2e8e90117e0632ad309f77ed18197