Bug 396056

Summary: building problems on windows 7 64bit
Product: [Applications] Falkon Reporter: Rami <rami>
Component: generalAssignee: David Rosca <nowrep>
Status: RESOLVED INTENTIONAL    
Severity: major CC: rami
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: Microsoft Windows   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: errors

Description Rami 2018-07-01 15:59:33 UTC
Created attachment 113685 [details]
errors

I almost managed to compile falkon on windows 7 64bit everything goes fine in-fact everything builds except for one thing flakonprivate.dll. also I would like to build on my local machine since it will make development & testing easier for me so I don't want to use appvayor...

Main problem is with 'IID_IApplicationActivationManager' I keep getting undeclared identifier C2065 + use of undefined type 'IApplicationActivationManager' more details of errors below...

example of errors:
1>registerqappassociation.cpp
1>d:\falkon-master\src\lib\other\registerqappassociation.cpp(281): error C2065: 'IID_IApplicationActivationManager': undeclared identifier
1>d:\falkon-master\src\lib\other\registerqappassociation.cpp(289): error C2027: use of undefined type 'IApplicationActivationManager'
1>c:\program files (x86)\windows kits\8.1\include\um\shobjidl.h(1459): note: see declaration of 'IApplicationActivationManager'
1>d:\falkon-master\src\lib\other\registerqappassociation.cpp(289): error C2227: left of '->ActivateApplication' must point to class/struct/union/generic type
1>d:\falkon-master\src\lib\other\registerqappassociation.cpp(292): error C2065: 'AO_NONE': undeclared identifier
1>d:\falkon-master\src\lib\other\registerqappassociation.cpp(300): error C2027: use of undefined type 'IApplicationActivationManager'
1>c:\program files (x86)\windows kits\8.1\include\um\shobjidl.h(1459): note: see declaration of 'IApplicationActivationManager'
1>d:\falkon-master\src\lib\other\registerqappassociation.cpp(300): error C2227: left of '->ActivateApplication' must point to class/struct/union/generic type
1>d:\falkon-master\src\lib\other\registerqappassociation.cpp(304): error C2065: 'AO_NONE': undeclared identifier
1>d:\falkon-master\src\lib\other\registerqappassociation.cpp(306): error C2027: use of undefined type 'IApplicationActivationManager'
1>c:\program files (x86)\windows kits\8.1\include\um\shobjidl.h(1459): note: see declaration of 'IApplicationActivationManager'
1>d:\falkon-master\src\lib\other\registerqappassociation.cpp(306): error C2227: left of '->Release' must point to class/struct/union/generic type
1>Done building project "FalkonPrivate.vcxproj" -- FAILED.

also attached capture of errors...


any idea whats needed to get this to build its just 1 final step! i know its related to windows version support but shouldnt it know im using windows 7? I have falkon.exe and everything else built just 1 thing remains the falkonprivate.dll and in-case it helps im building with MSVS2017 and Qt 5.11.1
Comment 1 David Rosca 2018-07-03 13:28:35 UTC
This is appveyor script that is used for Windows builds: https://github.com/srazi/Falkon-Release/blob/master/appveyor.yml

You should be able to replicate it in your environment.
Comment 2 Rami 2018-07-03 19:51:53 UTC
of cource I did replicate all what is required in my environment if I didnt I wouldn't have reached to the point where everything builds except the falkonprivate.dll issue keep in mind that I don't want to compile it on windows 2018 server I simply wish to achieve this on windows 7 this is why im reporting this try building on windows 7 it wont work cause you have something wrong it seems related to IApplicationActivationManager specifically the hex ID of windows I think?
Comment 3 David Rosca 2018-07-08 07:10:25 UTC
(In reply to Rami from comment #2)
> ... I don't want to compile it on windows 2018 server I simply
>  wish to achieve this on windows 7 

That's most likely your issue. You may try to fix it yourself and send a patch, but please don't reopen this bug.
It builds on current Windows version and on CI, which is the only platform that matters.