| Summary: | Dragging icons doesn't work most of the time | ||
|---|---|---|---|
| Product: | [Plasma] plasmashell | Reporter: | David Korth <gerbilsoft> |
| Component: | Containment | Assignee: | Sebastian Kügler <sebas> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | andrej, ascaris, bugseforuns, hein, jplx256, kde, nate, plasma-bugs, rgb.ide, smasha01, trmdi |
| Priority: | NOR | ||
| Version: | 5.14.5 | ||
| Target Milestone: | 1.0 | ||
| Platform: | Manjaro | ||
| OS: | Linux | ||
| URL: | https://bugreports.qt.io/browse/QTBUG-69246 | ||
| Latest Commit: | https://commits.kde.org/kdeclarative/856672f370fb32c7a3c3d1a13d873fb8b767d0e8 | Version Fixed In: | 5.56 |
| Sentry Crash Report: | |||
| Attachments: |
Video2
Video3 |
||
|
Description
David Korth
2018-06-30 06:12:41 UTC
Not able to reproduce with git master on Neon. Looks like a Qt bug and affects all places using Qml and drag and drop, e.g. dragging a file from Dolphin to the wallpaper dialog also shows the same erratic changing between accepted and denied cursor I'm using Qt 5.11.1. I'll file a bug upstream. Thanks! Please mention the Qt bug report URL here, and let's see what shakes out there. We can always re-open this if there's anything we need to do on our side. Upstream bug: https://bugreports.qt.io/browse/QTBUG-69246 Going to try creating a minimal test case, though I don't have too much experience with QML / Qt Quick. Thank you! *** Bug 395491 has been marked as a duplicate of this bug. *** *** Bug 399489 has been marked as a duplicate of this bug. *** upstream bug was closed because requested info was not provided. :( Eike, any chance you could take a look here when you get some breathing room? (In reply to Patrick Silva from comment #9) > upstream bug was closed because requested info was not provided. :( I can not reproduce the bug on that example. But the bug still happens on Plasma 5.14.0 / openSUSE Tumbleweed (In reply to trmdi from comment #11) > (In reply to Patrick Silva from comment #9) > > upstream bug was closed because requested info was not provided. :( > > I can not reproduce the bug on that example. > But the bug still happens on Plasma 5.14.0 / openSUSE Tumbleweed This means it's a Plasma bug ? Unfortunately I've never encountered this problem on any of my systems. Qt 5.12, though. (In reply to Eike Hein from comment #13) > Unfortunately I've never encountered this problem on any of my systems. Qt > 5.12, though. Just tried again. It doesn't happen with Folder view layout, but it does happen with Desktop Containment. I'm not sure I understand the bug report then, you may need to clarify for me. The original report talks about "When dragging a file icon on the desktop in Folder View". So you're talking a Folder View widget on top of Desktop Containment? Icons aren't movable in FV widgets. Or do you mean Icon widgets on top of Desktop Containment, and the original report is wrong? (In reply to Eike Hein from comment #15) > I'm not sure I understand the bug report then, you may need to clarify for > me. The original report talks about "When dragging a file icon on the > desktop in Folder View". So you're talking a Folder View widget on top of > Desktop Containment? Icons aren't movable in FV widgets. Or do you mean Icon > widgets on top of Desktop Containment, and the original report is wrong? See the video: https://bugs.kde.org/show_bug.cgi?id=395491 Created attachment 115843 [details] Video2 Summary: - Drag a file from Dolphin -> Desktop (Folder view layout) -> work 100% - Drag a file from Dolphin -> Desktop (Desktop containment layout) -> too difficult - Video: https://bugs.kde.org/show_bug.cgi?id=395491 - Drag an icon on Desktop (Folder view layout) from one place to another one -> too difficult - Video: [Video2] Thanks. I'll try to reproduce the Dolphin-related cases later. Dragging on FV is easy here, though. A new case: - Add widgets to the Plasma panel Created attachment 116043 [details]
Video3
Video3: add a widget to the Plasma panel is so difficult !!!
Possible patch: https://phabricator.kde.org/D16643 Patch D16643 fixes the issue for me for both desktop and panel widgets. Using KF 5.51, Plasma 5.14.2, and Qt 5.11.2. *** Bug 402606 has been marked as a duplicate of this bug. *** Patch D16643 fixes the issue for me as well. Manjaro 18.0.2 qt 5.12.0-3.0 plasma 5.14.5-2 Thanks trmdi Git commit 856672f370fb32c7a3c3d1a13d873fb8b767d0e8 by Fabian Vogt, on behalf of Tranter Madi. Committed on 05/02/2019 at 18:55. Pushed by fvogt into branch 'master'. Correct the accept flag of the event object on DragMove Summary: - `m_enabled` or `m_temporaryInhibition` could change while DragMove, so we should place `setAccepted()` on top of the function body. Otherwise, the accept flag of `event` could be wrong in the case `m_enabled` or `m_temporaryInhibition` changes while DragMove. - Don't call `setAccepted(false)` wrongly if `event->pos() == m_oldDragMovePo` Test Plan: - Drag a file from Dolphin -> Desktop (Desktop containment layout) -> too difficult -> fixed - Drag an icon on Desktop (Folder view layout) from one place to another one -> too difficult -> fixed - Add widgets to the Plasma panel -> too difficult -> fixed - Drag a file from Dolphin -> Desktop (Folder view layout) -> still easy Reviewers: mart, broulik, #plasma, hein, bruns Reviewed By: mart, #plasma Subscribers: fvogt, aacid, bruns, dkorth, ngraham, kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D16643 M +2 -3 src/qmlcontrols/draganddrop/DeclarativeDropArea.cpp https://commits.kde.org/kdeclarative/856672f370fb32c7a3c3d1a13d873fb8b767d0e8 Nice job, a great fix! |