Bug 395790

Summary: Rename with nested tags breaks due to | bar character
Product: [Applications] digikam Reporter: vilkmail
Component: AdvancedRename-metadataAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: caulier.gilles, metzpinguin
Priority: NOR    
Version: 5.9.0   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: Microsoft Windows   
Latest Commit: https://commits.kde.org/digikam/33234dc80d3162823e569b0f0bf67d96321e0dc9 Version Fixed In: 6.0.0
Sentry Crash Report:
Attachments: Calibre setup dialog with save ebook options to disk.

Description vilkmail 2018-06-23 14:09:46 UTC 
When renaming a file using "[file] - [meta:Xmp.digiKam.TagsList]" nested tags are separated by a bar | character, which is not a valid filename character in Windows 10. The rename fails at this point.

Example tags: Location|Paris
Comment 1 Maik Qualmann 2018-06-24 07:02:08 UTC 
All these characters are not allowed in Windows file names.

? * < >  , \ + : = / " ; [ ] |

What should we do?
1. Convert all characters under Linux and Windows? With which character replaced?
2. Check the file system and convert only FAT or NTFS these characters?

I would imagine that under Linux certain users use these characters.

Maik
Comment 2 caulier.gilles 2018-06-24 08:37:28 UTC 
Created attachment 113533 [details]
Calibre setup dialog with save ebook options to disk.
Comment 3 Maik Qualmann 2018-06-24 11:35:14 UTC 
Git commit 33234dc80d3162823e569b0f0bf67d96321e0dc9 by Maik Qualmann.
Committed on 24/06/2018 at 11:33.
Pushed by mqualmann into branch 'master'.

replace invalid characters under a Windows file system when renaming
Related: bug 391312
FIXED-IN: 6.0.0

M  +2    -1    NEWS
M  +11   -1    core/utilities/advancedrename/advancedrenamemanager.cpp

https://commits.kde.org/digikam/33234dc80d3162823e569b0f0bf67d96321e0dc9