| Summary: | Save session right after login crashes KWin | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | dckorah |
| Component: | general | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | brumbach_j, kde, leeh0117 |
| Priority: | NOR | Keywords: | drkonqi |
| Version: | 5.12.5 | ||
| Target Milestone: | --- | ||
| Platform: | Neon | ||
| OS: | Linux | ||
| Latest Commit: | https://commits.kde.org/kwin/835455939f4955baf88e2343c50b1df0f6e8cf5e | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
dckorah
2018-06-21 23:24:12 UTC
Heh, we added OnScreenDisplay as a type and this code isn't updated. Almost certainly that. Will fix. Git commit 2693e288c57a66facbe6b9932ce8628a53afb246 by David Edmundson. Committed on 27/06/2018 at 00:36. Pushed by davidedmundson into branch 'Plasma/5.13'. Avoid potential assert in SM saving Summary: Sesison Manager stores all relevant clients. There's an assert if the window type is outside of the standard client window types. It assumed that all windows outside this would be Unmanaged windows rather than Client objects, something probably true but not something enforced. This particular crash was probably cased as we have a new window type in Plasma OSD, which does not set BypassWindowManager in Qt window flags. Test Plan: Set to restore session Logged out and back in Saw some windows Set to restore manually saved session Hit save No crash Reviewers: #kwin, graesslin Reviewed By: #kwin, graesslin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D13715 M +8 -0 sm.cpp https://commits.kde.org/kwin/2693e288c57a66facbe6b9932ce8628a53afb246 *** Bug 399376 has been marked as a duplicate of this bug. *** *** Bug 406078 has been marked as a duplicate of this bug. *** Git commit 835455939f4955baf88e2343c50b1df0f6e8cf5e by David Edmundson. Committed on 31/03/2019 at 13:51. Pushed by davidedmundson into branch 'Plasma/5.12'. Avoid potential assert in SM saving Summary: Sesison Manager stores all relevant clients. There's an assert if the window type is outside of the standard client window types. It assumed that all windows outside this would be Unmanaged windows rather than Client objects, something probably true but not something enforced. This particular crash was probably cased as we have a new window type in Plasma OSD, which does not set BypassWindowManager in Qt window flags. Test Plan: Set to restore session Logged out and back in Saw some windows Set to restore manually saved session Hit save No crash Reviewers: #kwin, graesslin Reviewed By: #kwin, graesslin Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D13715 M +8 -0 sm.cpp https://commits.kde.org/kwin/835455939f4955baf88e2343c50b1df0f6e8cf5e |