Bug 395671

Summary:	Pressing enter key on lockscreen wont focus returning unlocking failed
Product:	[Plasma] kscreenlocker	Reporter:	Neousr <neousr>
Component:	greeter	Assignee:	Plasma Bugs List <plasma-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	alexkde, aspotashev, bhush94, bugseforuns, nate, notmart
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Neon
OS:	Linux
Latest Commit:	https://commits.kde.org/plasma-workspace/754efdedd4ee1b7dbafda06bd7858e2f51346ea0	Version Fixed In:	5.14.2
Sentry Crash Report:
Attachments:	lockscreen error

Description Neousr 2018-06-20 22:35:09 UTC

KDE Neon 5.13 User edition

Version: 5.13.1

After locking the system pressing enter will show the user and password prompt but it will not focus on the password box saying 'Unlocking failed' even if no password was actually typed.

Steps to Reproduce:

Lock the session
Press Enter
Unlocking failed message

After the error shows the box will regain focus allowing to enter the system.

Comment 1 Neousr 2018-06-21 02:23:34 UTC

Additional info:

OS KDE Neon 5.13 User edition

Version: 5.13.1

KDE Framework 5.47.0

QT Version 5.11.0

Waking the system from sleep mode will have the same effect.

And corrected a typo on the title.  Sorry about the double notification.

Comment 2 Neousr 2018-06-24 18:26:08 UTC

Created attachment 113543 [details]
lockscreen error

Adding a webm with the bug on action.

Steps to Reproduce:

1- Lock the screen
2- Wait until the username disappears
3- Press Enter

Unlocking failed message.

This bug is pretty similar to the one on 5.10  ID 380491 https://bugs.kde.org/show_bug.cgi?id=380491

It started to happen when the new blur effect debuted on 5.13.

Comment 3 Patrick Silva 2018-08-05 22:36:14 UTC

Also reproducible with plasma 5.13.4 on Arch Linux.

Comment 4 Thomas Surrel 2018-10-17 20:53:57 UTC

Git commit 754efdedd4ee1b7dbafda06bd7858e2f51346ea0 by Thomas Surrel.
Committed on 17/10/2018 at 20:53.
Pushed by thsurrel into branch 'Plasma/5.14'.

[Lock Screen] Do not try to unlock when unvisible

Summary:
In the lock screen, pressing the enter key while the UI is not yet
visible ends up trying to unlock (and would usually fail because the
password field is empty).
Ensure that the UI is visible before unlocking.

Test Plan:
Lock the session, press enter. The UI should appear without any
"Unlocking failed" message.

Reviewers: #plasma, #vdg, ngraham, davidedmundson

Reviewed By: #plasma, #vdg, ngraham, davidedmundson

Subscribers: ngraham, davidedmundson, abetts, filipf, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D16219

M  +1    -0    lookandfeel/contents/lockscreen/LockScreenUi.qml
M  +6    -1    lookandfeel/contents/lockscreen/MainBlock.qml

https://commits.kde.org/plasma-workspace/754efdedd4ee1b7dbafda06bd7858e2f51346ea0

Comment 5 Neousr 2018-10-18 03:55:37 UTC

Just tried this on neon unstable all the interactions/combinations work as expected (Enter, Intro and Escape). Waiting until this lands on 5.14.2. Appreciated.