Summary: | yakuake crashes on multiple touches on the touchscreen | ||
---|---|---|---|
Product: | [Applications] konsole | Reporter: | Leandro Santiago da Silva <leandrosansilva> |
Component: | copy-paste | Assignee: | Konsole Developer <konsole-devel> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | gaboxmail |
Priority: | NOR | Keywords: | drkonqi, junior-jobs |
Version: | 18.04.2 | ||
Target Milestone: | --- | ||
Platform: | Arch Linux | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/konsole/bfb91aac49f21b2bdf9ee2b64feaf28d87569bc4 | Version Fixed In: | |
Sentry Crash Report: |
Description
Leandro Santiago da Silva
2018-06-20 20:30:02 UTC
I mean, "whose screen supports up to 10 simultaneous touches" :-) QMimiData can be a nullptr in wayland, see e.g. https://cgit.kde.org/kolourpaint.git/commit/?id=4b280d0942b4c7b0248c96d0077ebab8c5a2673d *** Bug 396023 has been marked as a duplicate of this bug. *** I submitted a patch to fix this bug here https://phabricator.kde.org/D15794 Git commit bfb91aac49f21b2bdf9ee2b64feaf28d87569bc4 by Kurt Hindenburg. Committed on 30/09/2018 at 17:48. Pushed by hindenburg into branch 'master'. Check clipboard->mimeData() is valid Summary: Bug reported crashes on yakuake in a wayland session. Further investigation revealed that other KDE product Kolourpaint experienced nullptr on wayland while getting MimeData which was consistent with the stacktrace provided by the author of the bug. This diff validates the presence of MimeData before proceeding with the drag action. Test Plan: 1. Use wayland session 2. Open Yakuake in fullscreen 3. With a touch enabled laptop, scroll with many fingers (possibly 8) 4. Yakuake should not crash Reviewers: #konsole, hindenburg Reviewed By: #konsole, hindenburg Subscribers: anthonyfieroni, ngraham, konsole-devel Tags: #konsole Differential Revision: https://phabricator.kde.org/D15794 M +7 -3 src/TerminalDisplay.cpp https://commits.kde.org/konsole/bfb91aac49f21b2bdf9ee2b64feaf28d87569bc4 |