Bug 395605

Summary:	Converting to Paint layer selects wrong layer afterwards
Product:	[Applications] krita	Reporter:	Scott Petrovic <scottpetrovic>
Component:	Tools/Transform	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	NOR
Version First Reported In:	git master (please specify the git hash!)
Target Milestone:	---
Platform:	Other
OS:	Microsoft Windows
Latest Commit:	https://commits.kde.org/krita/a52008234ca27abda9e3c10218ac79b4ea77b10c	Version Fixed/Implemented In:
Sentry Crash Report:

Description Scott Petrovic 2018-06-19 12:44:07 UTC

I am trying out a new process of taking some things in the vector library and converting them to paint layers for further work. When I convert the vector layers to a paint layer. This is a bit inconvenient as I continue to do work and not realize I am on the wrong layer. 

Steps to reproduce

1. Go into the vector library and pull a vector shape on the canvas
2. Right click on the layer and convert to paint layer

Expected: 
Converted paint layer is still selected

Actual:
Layer below the converted layer is selected

Comment 1 Scott Petrovic 2018-06-19 13:33:23 UTC

I added a small patch that I think fixes it. It looks like the issue also happens with Clone layers being converted to paint layers, so I added that too for the patch.

http://phabricator.kde.org/D13609

Comment 2 Scott Petrovic 2018-06-21 22:16:30 UTC

Git commit c2bb2559e777604975fcd4a9ffee762e579abaeb by Scott Petrovic.
Committed on 21/06/2018 at 22:16.
Pushed by scottpetrovic into branch 'krita/4.1'.

M  +3    -3    libs/ui/kis_layer_manager.cc

https://commits.kde.org/krita/c2bb2559e777604975fcd4a9ffee762e579abaeb

Comment 3 Scott Petrovic 2018-06-21 22:17:45 UTC

Git commit 12b53fc7e1253dfd5a31836b4b737effafde9608 by Scott Petrovic.
Committed on 21/06/2018 at 22:17.
Pushed by scottpetrovic into branch 'master'.

(cherry picked from commit c2bb2559e777604975fcd4a9ffee762e579abaeb)

M  +3    -3    libs/ui/kis_layer_manager.cc

https://commits.kde.org/krita/12b53fc7e1253dfd5a31836b4b737effafde9608

Comment 4 Andrey 2018-06-26 15:02:54 UTC

Git commit a52008234ca27abda9e3c10218ac79b4ea77b10c by Andrey Kamakin, on behalf of Scott Petrovic.
Committed on 26/06/2018 at 14:18.
Pushed by akamakin into branch 'akamakin/T8628-multithreading-optimization'.

(cherry picked from commit c2bb2559e777604975fcd4a9ffee762e579abaeb)

M  +3    -3    libs/ui/kis_layer_manager.cc

https://commits.kde.org/krita/a52008234ca27abda9e3c10218ac79b4ea77b10c