| Summary: | [Move Tool] regression: no undo | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | David REVOY <info> |
| Component: | Tools/Move | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | normal | CC: | 7achoneus, brice.taillefer4, halla, isaaczuniga, konrad.papala, takiro-kde, tonyc |
| Priority: | NOR | ||
| Version: | git master (please specify the git hash!) | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
David REVOY
2018-06-14 18:16:49 UTC
Confirmed: I have this issue too. I have video showing it off here: https://drive.google.com/file/d/1Uy_RzcLdV7VLcdiVoQR5V6rVUkvdnTTL/view?usp=sharing Perhaps this could be a new tool/functionality that is currently a work in progress? Thank you @Isaac for taking the time to record a video about it. I'm switching the ticket to 'CONFIRMED'. I discussed about it yesterday with @Quiralta and he was able to also reproduce it. It looks like the move tool totally inhibit the "Undo" action during the action. One of the main problem: there is no user feedback on canvas an unfinished action is 'in progress'. So the Undo key just appears broken. Here are the hidden three option to unlock Undo stack avec a MoveTool action: 1. Switch to another tool (eg. switch to Freehand painting) then Undo works again. 2. Press <Esc> key on keyboard then Undo works again. 3. Pressing <ENTER> key bake the action and Undo works again. Proposal to solve this issue ============================ Option 1: Information -> Add an overlay notification in the corner of the canvas: "Move Tool action in progress" "<Enter> to validate - <Esc> to cancel" Option 2: Undo==Cancel -> During a MoveTool action, pressing <Ctrl+Z> resets the position. <Ctrl+Z>==Current <Esc> key behavior. As it was in 4.0.0 and all version prior that. (That my favorite) Option 3: Implement Undo history steps within MoveTool action (each position on release). -> Suggested in another long bug report, but I don't like that. It is always problematic. Move tool goes from a point A to a point B, imo. No need In-betweens steps. (or in this case, <Enter> to bake position is good enough) Same here. It also does not appear in the undo history docker anymore, which often was a way to work around similar issues. *** Bug 396260 has been marked as a duplicate of this bug. *** I just want to say that *Option 2: Undo==Cancel* is the most obvious and intuitive one :) So here is my up vote for it. If... this counts, probably not, but there it is anyway! :) Because it's soooo obvious. This was throwing me off quite a bit after updating Krita this morning. I hope there is an adjustment to this in the next update. It seems that David's option 3 is would be considered the "traditional" way of doing it, as it seems other programs like Gimp and Photoshop do it this way. But I think the confirmation method would work as well if David's option 2 is implemented. ctrl+z/Esc to cancel, any other action would confirm the transform. Actually, when I read about "Option 2: Undo==Cancel" it seemed so obvious, that I commented immediately. Now after reading the whole text, option 3 seems even better, indeed :) I'm pretty sure the problem starts here: commit f094f600e2e12f03181bb05ad291af6768a71b18 Author: Dmitry Kazakov <dimula73@gmail.com> Date: Wed Apr 4 16:06:12 2018 +0300 Disable handling Ctrl+Z as "cancel" action in KisToolMove Basically, we shouldn't cancel the stroke on undo in "continued" tool actions. Instead the user should use "Esc" key for that. Otherwise the previous command (the one that came before the current action) will be undone, which is not what the user wants. Ideally we should finally implement an undo system for the move tool, but it is still a todo. CCBUG:392014 *** This bug has been marked as a duplicate of bug 392014 *** |