Bug 395327

Summary: Split entry reports
Product: [Applications] kmymoney Reporter: ralph.goddard <ralph.goddard>
Component: reportsAssignee: KMyMoney Devel Mailing List <kmymoney-devel>
Status: CONFIRMED ---    
Severity: normal CC: ralf.habacker
Priority: NOR    
Version: 4.8.2   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: Microsoft Windows   
See Also: https://bugs.kde.org/show_bug.cgi?id=212097
https://bugs.kde.org/show_bug.cgi?id=330944
https://bugs.kde.org/show_bug.cgi?id=382245
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: E8FD0EDB59D8483FA3D70AB792FFA284.png
4549E1C87D754ACE8DE0553E03AAFA78.png
kmymoney test file
AED9FD841B9A4EC0BE2E6A4C3AF86FAD.png
kmymoney test file (update)
test case (update 2)

Description ralph.goddard@outlook.com 2018-06-13 17:10:52 UTC
KMM version 4.8.2 for Windows
Same as BUG reports 212097, 330944 and 382245. Reports not showing correct values for split transaction.  
Reports by Category total okay
Reports by Month do not total properly - ignores slit categories
Comment 1 Ralf Habacker 2018-06-13 20:02:31 UTC
Hi Ralph,

thanks for this bug report. I took a look at the mentioned bugs and found:
> Same as BUG reports 212097,  330944
these bugs were caused by user configuration and are not a kmymoney app issue
>and 382245
4.8.2 is not affected by this bug

If your issue is still present, please provide more information to be able to reproduce this issue either by appending a simple kmymoney test file showing the issue (please create a related report and mark it as favorite) or by reporting the detailed steps starting from a newly created file.
Comment 2 ralph.goddard@outlook.com 2018-06-13 21:19:17 UTC
Created attachment 113257 [details]
E8FD0EDB59D8483FA3D70AB792FFA284.png

I used actual data as there isn’t any personal info being shared.



From another Bug report dialog, I understand this is the way the program is designed and not a bug.  I find it very confusing as I only had AUTO&SUBS selected for the report.  Not being an accountant, I thought there was a filter problem with the REPORT by MONTH.



As you can see, there is a $245 difference between the two reports which is the TRAILER category amount.



If you tell me this is normal report behavior, then cancel my bug report and I’ll remember not to rely on MONTH reports where splits are concerned.



Report by month – only AUTO& SUBS categories selected

[cid:image001.png@01D4031F.07B88630]

Report by Category – only AUTO& SUBS categories selected

[cid:image002.png@01D4031F.CB3D2AC0]





Ralph
Sent from Mail for Windows 10



________________________________
From: Ralf Habacker <bugzilla_noreply@kde.org>
Sent: Wednesday, June 13, 2018 1:02:31 PM
To: ralph.goddard@outlook.com
Subject: [kmymoney] [Bug 395327] Split entry reports

https://bugs.kde.org/show_bug.cgi?id=395327

Ralf Habacker <ralf.habacker@freenet.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ralf.habacker@freenet.de
             Status|UNCONFIRMED                 |NEEDSINFO
         Resolution|---                         |WAITINGFORINFO

--- Comment #1 from Ralf Habacker <ralf.habacker@freenet.de> ---
Hi Ralph,

thanks for this bug report. I took a look at the mentioned bugs and found:
> Same as BUG reports 212097,  330944
these bugs were caused by user configuration and are not a kmymoney app issue
>and 382245
4.8.2 is not affected by this bug

If your issue is still present, please provide more information to be able to
reproduce this issue either by appending a simple kmymoney test file showing
the issue (please create a related report and mark it as favorite) or by
reporting the detailed steps starting from a newly created file.

--
You are receiving this mail because:
You reported the bug.
Comment 3 ralph.goddard@outlook.com 2018-06-13 21:19:18 UTC
Created attachment 113258 [details]
4549E1C87D754ACE8DE0553E03AAFA78.png
Comment 4 Ralf Habacker 2018-06-13 22:28:49 UTC
Created attachment 113260 [details]
kmymoney test file

I tried to reproduce the account/category structure and the transactions from the screenshots with the attached test file, but I did not see how the split transaction is structured. It would be helpful if you could adjust that in the test file
Comment 5 ralph.goddard@outlook.com 2018-06-13 22:36:20 UTC
Created attachment 113261 [details]
AED9FD841B9A4EC0BE2E6A4C3AF86FAD.png

Hopefully, this is what you wanted?



[cid:image001.png@01D4032C.266A6BE0]



Ralph
Sent from Mail for Windows 10



________________________________
From: Ralf Habacker <bugzilla_noreply@kde.org>
Sent: Wednesday, June 13, 2018 3:28:49 PM
To: ralph.goddard@outlook.com
Subject: [kmymoney] [Bug 395327] Split entry reports

https://bugs.kde.org/show_bug.cgi?id=395327

--- Comment #4 from Ralf Habacker <ralf.habacker@freenet.de> ---
Created attachment 113260 [details]
  --> https://bugs.kde.org/attachment.cgi?id=113260&action=edit
kmymoney test file

I tried to reproduce the account/category structure and the transactions from
the screenshots with the attached test file, but I did not see how the split
transaction is structured. It would be helpful if you could adjust that in the
test file

--
You are receiving this mail because:
You reported the bug.
Comment 6 Ralf Habacker 2018-06-13 22:58:30 UTC
Created attachment 113262 [details]
kmymoney test file (update)

Thanks for this pointer - the updated test file now contains all required transactions.

The transaction by category report generated with this file and disabled trailer  and subs category only shows the transaction split for auto:maintenance, which looks like what is expected.

In contrast, the monthly report with disabled trailer:maintenance category and sub categories contains all tranactions splits, which means that the category filter is ignored if a transaction contains a split. Compared to the first report this behavior looks inconsequent and therefore seems to be a bug.
Comment 7 Ralf Habacker 2018-06-29 22:27:49 UTC
see https://phabricator.kde.org/D13803 for a related review
Comment 8 Ralf Habacker 2018-06-30 08:31:29 UTC
Created attachment 113654 [details]
test case (update 2)

setup reports "category(without trailer)" and "month (without trailer)" showing the difference
Comment 9 Ralf Habacker 2018-07-08 08:09:02 UTC
KMymoney 5.0.2 is also affected by this bug and show the same issue
Comment 10 Ralf Habacker 2018-09-20 20:10:21 UTC
Git commit cc670b1a8733ab3f2b4c5640122d661390575c76 by Ralf Habacker.
Committed on 20/09/2018 at 20:09.
Pushed by habacker into branch '5.0'.

Add test for MyMoneyTransactionFilter

This test was created to check the basic functions of the transaction
filter, but does not claim to be complete. It was written by me for 4.8
and ported from Thomas Baumgart to KF5.
Test Plan: compiled and tested on linux
Reviewers: wojnilowicz
Signed-off-by: Ralf Habacker <ralf.habacker@freenet.de>
Differential Revision: https://phabricator.kde.org/D15107

M  +1    -1    kmymoney/mymoney/mymoneytransactionfilter.cpp
M  +4    -3    kmymoney/mymoney/mymoneytransactionfilter.h
A  +787  -0    kmymoney/mymoney/tests/mymoneytransactionfilter-test.cpp     [License: GPL (v2+)]
A  +58   -0    kmymoney/mymoney/tests/mymoneytransactionfilter-test.h     [License: GPL (v2+)]

https://commits.kde.org/kmymoney/cc670b1a8733ab3f2b4c5640122d661390575c76
Comment 11 Ralf Habacker 2018-09-20 20:55:39 UTC
Git commit 4ed579e86be69ce5df04c03e4b9797108ec8cfa8 by Ralf Habacker.
Committed on 20/09/2018 at 20:55.
Pushed by habacker into branch '4.8'.

Add MyMoneyTransactionFilterTest
Signed-off-by: Ralf Habacker <ralf.habacker@freenet.de>
Differential Revision: https://phabricator.kde.org/D15010

M  +6    -0    kmymoney/mymoney/CMakeLists.txt
M  +1    -1    kmymoney/mymoney/mymoneytransactionfilter.cpp
M  +3    -2    kmymoney/mymoney/mymoneytransactionfilter.h
A  +805  -0    kmymoney/mymoney/mymoneytransactionfiltertest.cpp     [License: GPL (v2+)]
A  +48   -0    kmymoney/mymoney/mymoneytransactionfiltertest.h     [License: GPL (v2+)]

https://commits.kde.org/kmymoney/4ed579e86be69ce5df04c03e4b9797108ec8cfa8
Comment 12 Ralf Habacker 2018-09-28 19:04:51 UTC
Git commit 55eb90e55389f7a93c77a7fcf39d0c5a171ad9b6 by Ralf Habacker.
Committed on 28/09/2018 at 19:04.
Pushed by habacker into branch '4.8'.

kmymoneytransactionfiltertest: add 'same date' and 'bad date order' test

M  +9    -0    kmymoney/mymoney/mymoneytransactionfiltertest.cpp

https://commits.kde.org/kmymoney/55eb90e55389f7a93c77a7fcf39d0c5a171ad9b6
Comment 13 Bug Janitor Service 2024-09-05 15:53:17 UTC
A possibly relevant merge request was started @ https://invent.kde.org/office/kmymoney/-/merge_requests/230