| Summary: | ssh:// link opens konsole with --noclose | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kio | Reporter: | tony den haan <kdebugs> |
| Component: | general | Assignee: | David Faure <faure> |
| Status: | CONFIRMED --- | ||
| Severity: | normal | CC: | a.samirh78, kdelibs-bugs, rdieter |
| Priority: | NOR | ||
| Version: | git master | ||
| Target Milestone: | --- | ||
| Platform: | Ubuntu | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
|
Description
tony den haan
2018-06-05 14:58:04 UTC
Triaging to kio, owner of ktelnetservice.cpp that includes the code snippet:
if (terminal == QLatin1String("konsole")) {
cmd << QStringLiteral("--noclose");
}
Unsure of the reasoning or rationale for including that, git history didn't include anything I could find.
I tested this a bit (with `kde-open5 ssh://someIPAddress`) and using --noclose sort of makes sense. Consider the case where you try connecting to an ssh server and the connection fails for whatever reason, without "--noclose" you'll get a konsole window that'll show for a fraction of a second and close; whereas with "--noclose", if the connection fails the window won't go away, but will display an error message, something like: ssh: Could not resolve hostname 192.168.1.300: Name or service not known IIUC, this is the intended behaviour. Since the condition in the code is checking that "konsole" is set as the default terminal emulator, you can tweak the default behaviour from systemsettings5 -> Applications -> Default Applications -> Terminal Emulator, change "Use Konsole ..." to "Use a different terminal program" and enter /usr/bin/konsole in the edit line box; so you'll still be using konsole but the condition will evaluate to false and "--noclose" won't be used. Aha thanks, that sure makes sense. Yet i'd rather have it drop to local shell, both after closing ssh sesession and on ssh failure. But i suppose that's not for this report. |