Summary: | Animation timeline's "Remove Frames and Pull" works inconsistently when the frame after the currently selected frame is null/empty/hold. | ||
---|---|---|---|
Product: | [Applications] krita | Reporter: | Emmet O'Neill <emmetoneill.pdx> |
Component: | Animation | Assignee: | Emmet O'Neill <emmetoneill.pdx> |
Status: | RESOLVED FIXED | ||
Severity: | minor | ||
Priority: | NOR | ||
Version: | git master (please specify the git hash!) | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/krita/2a7e1f2dc01c5db16c837172fbb6b927916251fa | Version Fixed In: | |
Attachments: | Krita file for testing for this bug. |
Description
Emmet O'Neill
2018-05-29 22:29:52 UTC
Created attachment 113105 [details]
Krita file for testing for this bug.
Here's a krita file for testing for this bug. Frames contain letters from A to G.
Select the frame containing "D" and activate"Remove Frames and Pull"; it works correctly, removing the frame containing "D" and pulling/shifting all subsequent frames back.
Then select the frame containing "E" and activate "Remove Frames and Pull"; this does not work correctly, the "E" frame is not actually removed, even though subsequent frames are still shifted back.
Git commit b2ae65a7456245caac86c37103e1fe8d7d5273b9 by Emmet O'Neill. Committed on 06/06/2018 at 18:51. Pushed by emmetoneill into branch 'master'. Fixed Timeline's "Remove Frames/Columns and Pull" Actions. Previously these actions failed to remove the last frame of the selection if the next following frame was empty. Fixed now! Revied by Dmitry. Help from Eoin. Thanks as always! M +1 -2 plugins/dockers/animation/kis_animation_curves_model.cpp M +37 -33 plugins/dockers/animation/kis_animation_utils.cpp M +4 -4 plugins/dockers/animation/kis_animation_utils.h M +12 -14 plugins/dockers/animation/kis_time_based_item_model.cpp M +4 -2 plugins/dockers/animation/kis_time_based_item_model.h M +4 -4 plugins/dockers/animation/tests/kis_animation_utils_test.cpp M +3 -3 plugins/dockers/animation/timeline_frames_model.cpp M +11 -10 plugins/dockers/animation/timeline_frames_view.cpp M +1 -1 plugins/dockers/animation/timeline_frames_view.h https://commits.kde.org/krita/b2ae65a7456245caac86c37103e1fe8d7d5273b9 Git commit 2a7e1f2dc01c5db16c837172fbb6b927916251fa by Andrey Kamakin, on behalf of Emmet O'Neill. Committed on 26/06/2018 at 14:18. Pushed by akamakin into branch 'akamakin/T8628-multithreading-optimization'. Fixed Timeline's "Remove Frames/Columns and Pull" Actions. Previously these actions failed to remove the last frame of the selection if the next following frame was empty. Fixed now! Revied by Dmitry. Help from Eoin. Thanks as always! M +1 -2 plugins/dockers/animation/kis_animation_curves_model.cpp M +37 -33 plugins/dockers/animation/kis_animation_utils.cpp M +4 -4 plugins/dockers/animation/kis_animation_utils.h M +12 -14 plugins/dockers/animation/kis_time_based_item_model.cpp M +4 -2 plugins/dockers/animation/kis_time_based_item_model.h M +4 -4 plugins/dockers/animation/tests/kis_animation_utils_test.cpp M +3 -3 plugins/dockers/animation/timeline_frames_model.cpp M +11 -10 plugins/dockers/animation/timeline_frames_view.cpp M +1 -1 plugins/dockers/animation/timeline_frames_view.h https://commits.kde.org/krita/2a7e1f2dc01c5db16c837172fbb6b927916251fa |