Bug 394809

Summary: The Env. Canada data source has a 13 day forecast which shows up squished in the widget
Product: [Unmaintained] kdeplasma-addons Reporter: Chris Holland <zrenfire>
Component: WeatherAssignee: Plasma Bugs List <plasma-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: bharadwaj.raju777, nate, plasma-bugs-null
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: https://invent.kde.org/plasma/kdeplasma-addons/commit/1516dc73a16b9f72fec1315ac3d63f27147dd696 Version Fixed/Implemented In: 5.27
Sentry Crash Report:

Description Chris Holland 2018-05-28 21:00:25 UTC 
EnvCan 13 day forecast: https://i.imgur.com/FxgSYud.png
Wetter 4 day forecast: https://i.imgur.com/pGk2OZt.png
BBC 3 day forecast: https://i.imgur.com/4WjfbK8.png
NOAA 7 day forecast: https://i.imgur.com/4PJjd7A.png
NOAA only shows the current temp in Canada: https://i.imgur.com/8QCtZ97.png

The cramped look was noticed by this reddit user:
https://www.reddit.com/r/kde/comments/8mskp2/weather_widget_looking_bad_minimize_windows_button/


I think it should have a limit of a 7 day forecast unless it detects there's enough room for all 13 days.
Comment 2 Bug Janitor Service 2022-11-20 15:02:30 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/plasma/kdeplasma-addons/-/merge_requests/278
Comment 3 Ismael Asensio 2022-11-21 22:35:45 UTC 
Git commit 1516dc73a16b9f72fec1315ac3d63f27147dd696 by Ismael Asensio.
Committed on 21/11/2022 at 21:55.
Pushed by iasensio into branch 'master'.

applets/weather: Show forecast in two rows for envcan provider

The envcan provider (Environment Canada Service) produces a
forecast model with 13 items (7-day forecast and 6 nights).

Show them on a two row layout, so its easier to visually parse
and helps avoiding visual bugs on constrained spaces (system
tray popup) due to a really long width.

Ideally, this would be better set-up by the dataengine but,
since they will be deprecated soon and there are alreay too many
indirection layers we can do an educated guess here.
Related: bug 452792
FIXED-IN: 5.27

M  +24   -8    applets/weather/package/contents/ui/ForecastView.qml
M  +1    -0    applets/weather/package/contents/ui/FullRepresentation.qml
M  +1    -0    applets/weather/package/contents/ui/SwitchPanel.qml
M  +22   -2    applets/weather/package/contents/ui/main.qml

https://invent.kde.org/plasma/kdeplasma-addons/commit/1516dc73a16b9f72fec1315ac3d63f27147dd696