Bug 394731

Summary: allow building if arch=amd64 instead of x86-64
Product: [Developer tools] valgrind Reporter: Eitan Adler <lists>
Component: generalAssignee: Julian Seward <jseward>
Status: RESOLVED LATER    
Severity: normal CC: philippe.waroquiers
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: Other   
OS: All   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: allow building on amd64

Description Eitan Adler 2018-05-27 01:57:43 UTC
Created attachment 112898 [details]
allow building on amd64

Some platforms report 64-bit x86 as amd64. Allow building on such systems.
Comment 1 Philippe Waroquiers 2018-05-29 19:24:09 UTC
Which platforms are reporting amd64 ?
Comment 2 Philippe Waroquiers 2018-05-29 19:27:13 UTC
(when testing on a amd64 cpu machine, it does not need this patch)
Comment 3 Eitan Adler 2018-05-30 08:23:20 UTC
This was the start of me upstreaming some of the work done to make valgrind work on FreeBSD. Generally I start with a tiny patch to learn how the development process works for a given project.

FWIW after more investigation the actual work to do is much more than I thought, so while I'll still be looking, it'll be slower than I thought.
Comment 4 Julian Seward 2018-09-03 07:00:45 UTC
I think this is a misunderstanding of terminology.  "amd64" means the
64-bit x86 architecture.  It has that name because it was AMD that
defined the 64-bit extension to the 32-bit x86 architecture.
Comment 5 Eitan Adler 2018-09-04 03:59:07 UTC
This is not a misunderstanding of terminology. You are correct that amd64 is also known as x86_64 in some circles. However, on many modern systems

∴uname -m
amd64
∴uname -p
amd64

which breaks configuring the system. 

This was intended to be the first of several patches to make compiling valgrind possible, but I've since had to focus on other things.

Re-opening to re-close under a correct status
Comment 6 Eitan Adler 2018-09-04 04:00:18 UTC
Actually fixing valgrind to compile requires a larger patch, and based on my own free time, it doesn't make sense to leave this open unless others contribute.

Marked as "LATER" so that hopefully someone might pick it up.