Bug 394497

Summary:	The --include-dependencies option breaks --ignore-modules
Product:	[Developer tools] kdesrc-build	Reporter:	Michael Pyne <mpyne>
Component:	general	Assignee:	Michael Pyne <mpyne>
Status:	RESOLVED FIXED
Severity:	normal	CC:	ongun.kanat
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Michael Pyne 2018-05-21 02:53:52 UTC

It is impossible to filter out modules in a kdesrc-build run using --ignore-modules [modules ... ], either at cmdline or in the rcfile, if those modules would be picked up by --include-dependencies.

Testcase:

"kdesrc-build --include-dependencies -p dolphin --ignore-modules khtml" should avoid building KHTML, but does not.  The same is true if equivalent options are set in the config file.

Reported on IRC.

Comment 1 Michael Pyne 2018-05-25 04:15:25 UTC

So I took a look today and tested a few fixes locally on my system, but still haven't fully resolved. Though it seems to me at this point that it won't be as easy as I was thinking to figure out. :(

Comment 2 Michael Pyne 2018-05-27 20:51:34 UTC

Git commit ca30f09b511e1058a6f47ed43f1e9d1ced118bd8 by Michael Pyne.
Committed on 27/05/2018 at 20:36.
Pushed by mpyne into branch 'master'.

Add testcase for bug 394497 (ignore-modules/include-dependencies).

This adds a testcase that would fail without the bugfix for bug 394497
and now passes.

This did require undoing some of the changes to generateModuleList but
the only real behavior change (beside merging duplicate ignored module
checks) was to move the step that generates module dependencies to occur
earlier so that it can happen before the filter steps

M  +42   -47   modules/ksb/Application.pm
A  +51   -0    t/bug-394497-ignore-dep-module.t

https://commits.kde.org/kdesrc-build/ca30f09b511e1058a6f47ed43f1e9d1ced118bd8