Bug 394496

Summary:	KTorrent sends upload_only as a string
Product:	[Applications] ktorrent	Reporter:	Juliusz Chroboczek <jch>
Component:	general	Assignee:	Joris Guisson <joris.guisson>
Status:	RESOLVED FIXED
Severity:	normal	CC:	jackhill3103
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:	https://invent.kde.org/network/libktorrent/-/commit/cf650071262a9a51336d9279e21a2cecfacfcef6	Version Fixed In:
Sentry Crash Report:

Description Juliusz Chroboczek 2018-05-21 00:42:18 UTC

I've just received an Extended TLV from KTorrent that looks like this:

0000   00 00 00 75 14 00 64 31 3a 6d 64 36 3a 75 74 5f  ...u..d1:md6:ut_
0010   70 65 78 69 31 65 31 31 3a 75 74 5f 6d 65 74 61  pexi1e11:ut_meta
0020   64 61 74 61 69 32 65 65 31 3a 70 69 36 38 38 31  datai2ee1:pi6881
0030   65 34 3a 72 65 71 71 69 32 35 30 65 31 33 3a 6d  e4:reqqi250e13:m
0040   65 74 61 64 61 74 61 5f 73 69 7a 65 69 32 33 33  etadata_sizei233
0050   37 37 65 31 31 3a 75 70 6c 6f 61 64 5f 6f 6e 6c  77e11:upload_onl
0060   79 31 3a 30 31 3a 76 31 34 3a 4b 54 6f 72 72 65  y1:01:v14:KTorre
0070   6e 74 2f 34 2e 33 2e 31 65                       nt/4.3.1e

Note that the upload_only value is a string, while according to BEP-21 it should be an integer (11:upload_only:i1e).  I suggest that KTorrent should either omit the upload_only key, or send it as an integer.  Implementing the

Comment 1 Justin Zobel 2022-11-21 08:21:42 UTC

Thank you for reporting this issue in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version?

If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you!

Comment 2 Bug Janitor Service 2022-12-06 05:18:15 UTC

Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!

Comment 3 Juliusz Chroboczek 2022-12-06 11:50:48 UTC

Let me get this clear.

I report a bug in your software.  After four year of silence, you suddenly request that I do the work again?

Sorry, but that's now how it works.

Comment 4 Bug Janitor Service 2023-11-09 16:02:21 UTC

A possibly relevant merge request was started @ https://invent.kde.org/network/libktorrent/-/merge_requests/53