Bug 394236

Summary: logout confirmation dialog is unreadable with certain light backgrounds and some 3rd party themes
Product: [Plasma] plasmashell Reporter: luca <luca.pedrielli>
Component: Theme - BreezeAssignee: visual-design
Severity: minor CC: husek, nate, plasma-bugs
Priority: NOR Keywords: usability
Version: 5.12.5   
Target Milestone: 1.0   
Platform: Debian testing   
OS: Linux   
See Also: https://bugs.kde.org/show_bug.cgi?id=382264
Latest Commit: Version Fixed In:
Attachments: screenshot
screenshot3 - breeze desktop theme

Description luca 2018-05-14 08:33:48 UTC
after 5.12.5 plasma update the logout confirmation dialog is white with white buttons and white font color.

as workaround I changed /usr/share/plasma/look-and-feel/org.kde.breeze.desktop/contents/logout/Logout.qml

        //color: root.isLightColor(PlasmaCore.ColorScope.backgroundColor) ? PlasmaCore.ColorScope.backgroundColor : "black"
        color: "black"
Comment 1 Nate Graham 2018-05-14 19:05:22 UTC
Can you provide a screenshot?
Comment 2 luca 2018-05-14 19:13:42 UTC
Created attachment 112651 [details]

here it is
Comment 3 Nate Graham 2018-05-14 19:31:59 UTC
Thanks. Looks like the lightness calculation that was changed for Bug 382264 is mis-perceiving this background as dark instead of light. Perhaps because of the black terminal window?

We should just unconditionally darken everything IMHO instead of playing color games like this.
Comment 4 Radek Hušek 2018-05-14 19:42:17 UTC
The color which decides whether make the background darker or lighter is the button background -- the color of OK button on the screenshot -- which is some kind of light blue so it is considered light background since the mentioned patch. IMHO even the buttons are hard to read which seems to be the root of the problem to me. Or is this color combination intentional?
Comment 5 Nate Graham 2018-05-14 19:45:51 UTC
Right, the issue in the screenshot is that the buttons are hard to read because their text is white, and also the leave options buttons are practically invisible because they're white against a light background.

Even if we fixed the button text to be black in this case, IMHO because the leave options are always white, we need to always darken, never lighten. Whenever we lighten, the leave options buttons are going to be unreadable. Does that make sense?
Comment 6 luca 2018-05-14 19:51:29 UTC
Created attachment 112653 [details]

desktop with simple white color background
Comment 7 luca 2018-05-14 19:53:41 UTC
button background seems to be transparent
Comment 8 Radek Hušek 2018-05-14 19:54:51 UTC
That's the thing, leave options are not always white but their color is foreground color of complementary color group...
Comment 9 Radek Hušek 2018-05-14 20:32:39 UTC
Yes the background seems to be transparent. I didn't know it was possible / supported. Which desktop theme are you using?
Comment 10 luca 2018-05-14 20:56:54 UTC
I've noticed this issue with "glassified" and "ktrans" desktop theme.
Seems ok with breeze desktop themes.
Comment 11 Nate Graham 2018-05-14 21:04:09 UTC
Can you attach a screenshot with regular Breeze?
Comment 12 luca 2018-05-15 05:35:14 UTC
Created attachment 112660 [details]
screenshot3 - breeze desktop theme
Comment 13 Nate Graham 2018-05-15 21:15:20 UTC
Thanks. I'm tempted to mark this as RESOLVED DOWNSTREAM since it's caused by 3rd-party themes using transparency in a somewhat inappropriate manner...
Comment 14 Nate Graham 2018-05-15 21:16:54 UTC
Yeah, this is a theme issue. It's not appropriate to use such heavy transparency for button backgrounds, since buttons need to be readable no matter what they're placed over. Please report this issue to the maintainers of the affected themes. Thanks!