Bug 394180

Summary: Broken "force fonts dpi" behaviour
Product: [Applications] systemsettings Reporter: Fabian Vogt <fabian>
Component: kcm_fontsAssignee: Marco Martin <notmart>
Severity: normal CC: christophe, kde, nate, unassigned-bugs, wolff
Priority: NOR Flags: fabian: Usability+
Version: 5.12.90   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Fabian Vogt 2018-05-12 22:21:38 UTC
It got reported that it no longer works to just force Xft.dpi: 96.
The checkbox checking does not enable the Apply button.

I also noticed that it only allows to set certain predefined values, which I consider a regression. Some set the dpi to make it easier to read, which might just as well be 110dpi.
Comment 1 Fabian Vogt 2018-05-19 13:36:27 UTC
Still present in 5.12.90.
Comment 2 David Edmundson 2018-05-23 01:26:42 UTC
fix on phab
Comment 3 David Edmundson 2018-05-23 09:40:29 UTC
Git commit b2694cfc64de7e6a11fd5ba91f9bacb01b6ad9de by David Edmundson.
Committed on 23/05/2018 at 09:40.
Pushed by davidedmundson into branch 'Plasma/5.13'.

Fix Font KCM force font DPI checkbox

Fixes numerous issues:

1) the default behaviour had changed. It should disable force font DPI,
not set it to 96
2) disabling didn't work, we'd set the value to 0, which would update
the spinbox, which has a minimum which sets the value to 96 (we were
warned of this with a binding loop error)
3) toggling the checkbox didn't enable the apply button

New code fixes that and is more declarative too.

Test Plan: Toggled, reset to defaults, restarted

Reviewers: #plasma, progwolff, broulik

Reviewed By: #plasma, progwolff, broulik

Subscribers: broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D13051

M  +1    -1    kcms/fonts/fonts.cpp
M  +7    -10   kcms/fonts/package/contents/ui/main.qml