Bug 394096

Summary:	Validate appdata.xml with appstream-util
Product:	[Applications] krita	Reporter:	Peter Eszlari <peter.eszlari>
Component:	Documentation	Assignee:	Krita Bugs <krita-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	halla
Priority:	NOR
Version First Reported In:	git master (please specify the git hash!)
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Peter Eszlari 2018-05-10 16:18:12 UTC

The appdata.xml file in the 4.0 branch has a duplicated screenshot entry:

$ appstream-util validate-relax org.kde.krita.appdata.xml
org.kde.krita.appdata.xml: FAILED:
? tag-invalid           : <screenshot> content was duplicated
Validation of files failed


Flatpak expects "validate-relax" to pass, but passing "validate-strict" would of course be even better (needs someone to upload adjusted screenshots, among other things).

Comment 1 Peter Eszlari 2018-05-10 16:52:20 UTC

For reference, the output of "validate-strict":

$ appstream-util validate-strict org.kde.krita.appdata.xml 
org.kde.krita.appdata.xml: FAILED:
? tag-missing           : <project_license> is not present
? tag-missing           : <translation> not specified
? value-missing         : <!-- Copyright [year] [name] --> is not present
? tag-invalid           : <screenshot> content was duplicated
? attribute-invalid     : <screenshot> width too large [https://cdn.kde.org/screenshots/krita/2018-03-17_screenshot_001.png] maximum is 1600px
? attribute-invalid     : <screenshot> height too large [https://cdn.kde.org/screenshots/krita/2018-03-17_screenshot_001.png] maximum is 900px
? attribute-invalid     : <screenshot> width too large [https://cdn.kde.org/screenshots/krita/2018-03-17_screenshot_005.png] maximum is 1600px
? attribute-invalid     : <screenshot> height too large [https://cdn.kde.org/screenshots/krita/2018-03-17_screenshot_005.png] maximum is 900px
? attribute-invalid     : <screenshot> width too large [https://cdn.kde.org/screenshots/krita/2018-03-17_screenshot_004.png] maximum is 1600px
? attribute-invalid     : <screenshot> height too large [https://cdn.kde.org/screenshots/krita/2018-03-17_screenshot_004.png] maximum is 900px
? aspect-ratio-invalid  : <screenshot> aspect ratio not 16:9 [https://cdn.kde.org/screenshots/krita/2018-03-17_screenshot_004.png]
? attribute-invalid     : <screenshot> width too large [https://cdn.kde.org/screenshots/krita/2018-03-17_screenshot_003.png] maximum is 1600px
? attribute-invalid     : <screenshot> height too large [https://cdn.kde.org/screenshots/krita/2018-03-17_screenshot_003.png] maximum is 900px
? attribute-invalid     : <screenshot> width too large [https://cdn.kde.org/screenshots/krita/2018-03-17_screenshot_002.png] maximum is 1600px
? attribute-invalid     : <screenshot> height too large [https://cdn.kde.org/screenshots/krita/2018-03-17_screenshot_002.png] maximum is 900px
? aspect-ratio-invalid  : <screenshot> aspect ratio not 16:9 [https://cdn.kde.org/screenshots/krita/2018-03-17_screenshot_002.png]
? style-invalid         : <p> is too short [It is perfect for sketching and painting, and presents an end?to?end solution for creating digital painting files from scratch by masters.]
Validation of files failed

Comment 2 Halla Rempt 2018-05-12 18:41:38 UTC

I pushed your patches, btw. I think the complaints about screenshots and a paragraph that is too short are a bit over the top...

Comment 3 Halla Rempt 2018-06-20 21:31:35 UTC

Please make a diff on phabricator if there are still things to do, let's not clutter up bugzilla with this. If you want direct push access to maintain this file, that's fine as well. Follow https://community.kde.org/Infrastructure/Get_a_Developer_Account and mention me as the sponsor.