Bug 394077

Summary:	KDE-free build dependencies
Product:	[Applications] Falkon	Reporter:	speps <speps>
Component:	general	Assignee:	David Rosca <nowrep>
Status:	RESOLVED NOT A BUG
Severity:	normal
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description speps 2018-05-10 10:50:05 UTC

With Falkon 3.0.1, its build system now rely on KF5I18n as mandatory requirement [1][2].

As stated in the blog post announcing the moving of QupZilla under the KDE infrastructure [3] as the new Falkon browser:

"There will be no changes in project goals - all platforms currently supported will stay supported and there will be no hard dependencies on KDE libraries"

The build system itself should take care of the statement and not to fail when the optional KDE dependencies are not met (as it was till 3.0.0).

The official source tarball [4] cointains the ./po subfolder, so, as defined in CMakeLists.txt [4], it would make KF5I18n REQUIRED, that relies on KDE libraries and fails without.

A solution would be to not ship the ./po folder (it just contains the hellopython translations) within the source tarball and/or to double check the possibility to rely on KF5I18n.

[1]: https://phabricator.kde.org/R875:288585f91a69100d7579aec859c9f6fe3516fa53
[2]: https://phabricator.kde.org/R875:265c67f173d4819c786d14ccdd6e3bc539c6fa80
[3]: http://blog.qupzilla.com/2017/08/qupzilla-is-moving-under-kde-and.html
[4]: https://download.kde.org/stable/falkon/3.0.1/falkon-3.0.1.tar.xz
[5]: https://phabricator.kde.org/source/falkon/browse/master/CMakeLists.txt;3760a9ffd173ec2b228d5f9a26c541275a994639$92

Comment 1 David Rosca 2018-05-10 11:13:50 UTC

Just remove "po" directory if you don't want translations, and then it won't look for KI18n.

Also KI18n is Tier 1 Framework (only depends on Qt), so I see no problem here. It is just a matter of depending on one more library, it doesn't pull all KDE Frameworks.

Comment 2 speps 2018-05-10 13:31:21 UTC

(In reply to David Rosca from comment #1)
> Just remove "po" directory if you don't want translations, and then it won't
> look for KI18n.

As I already mentioned, actually all the translations (but the hellokitty one) are in the ./poqm folder, so they got processed right by cmake, installed and working without ki18n.

Why hellokitty belongs to "po" and why it could not be part of "poqm"?

> Also KI18n is Tier 1 Framework (only depends on Qt), so I see no problem
> here. It is just a matter of depending on one more library, it doesn't pull
> all KDE Frameworks.

Surely. KI18n does not depend on the KDE framework libraries, but it is still part of it.
I agree with your point, my only big concern here is if this would be the first step of a gradually Falkon strong integration into KDE and a relative conversion into a no more DE agnostic browser.

I hope this is not the case.

Thanks for your work.