| Summary: | kwinrulesrc rewritten unnecessarily | ||
|---|---|---|---|
| Product: | [Plasma] kwin | Reporter: | Antonio Russo <aerusso> |
| Component: | rules | Assignee: | KWin default assignee <kwin-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | grave | Flags: | mgraesslin:
ReviewRequest+
|
| Priority: | NOR | ||
| Version First Reported In: | 5.12.4 | ||
| Target Milestone: | --- | ||
| Platform: | Debian unstable | ||
| OS: | Linux | ||
| URL: | https://phabricator.kde.org/D12749 | ||
| Latest Commit: | https://commits.kde.org/kwin/9a02ed4d360ffa18c3c406ab0eb1d01ccc9c0901 | Version Fixed/Implemented In: | 5.12.6 |
| Sentry Crash Report: | |||
|
Description
Antonio Russo
2018-05-06 15:00:24 UTC
The reason for the behavior is that there are temporary rules which might be removed. In those cases we need to sync. But if the rules didn't change there is no need to sync. That can hopefully be improved. Not sure about not blocking - iirc kconfig is not thread save. > ~/.config/kwinrulesrc appears to be modified (stat shows changed times) every time a window is created
I could confirm this by reading the code. This happens from discard used rules to remove force temporary rules. But it doesn't check whether there are any temporary rules at all and triggers an update for saving.
Also window removing triggers discardUsed. So it's just one place to fix it all and I have already a patch. Patch at: https://phabricator.kde.org/D12749 If you could test and verify that the issue is fixed, this would be appreciated. Thanks! After patching, I'm not seeing the unnecessary updates anymore. (The original symptom was *terrible* lag when opening new Konsole windows during a ZFS scrub) Great! Thanks for testing Git commit 9a02ed4d360ffa18c3c406ab0eb1d01ccc9c0901 by Martin Flöser. Committed on 20/05/2018 at 13:40. Pushed by graesslin into branch 'Plasma/5.12'. Do not save kwinrulesrc on every window opening/closing Summary: Our rule handling has had a grave error for years. Whenever a window with a rule was openend or closed the kwinrulesrc was written back to disk. The reason for this behavior is that temporary rules need to be discarded once they were used. For that there is a method discardUsed which invokes requestDiskStorage whenever a rule for the window was found. But it did not check whether there was a rule requiring this. This change modifies the discardUsed to track whether it changed a rule and only writes back in case there was a change. FIXED-IN: 5.12.6 Test Plan: Only compile tested Reviewers: #kwin, #plasma Subscribers: kwin Tags: #kwin Differential Revision: https://phabricator.kde.org/D12749 M +13 -5 rules.cpp M +1 -1 rules.h https://commits.kde.org/kwin/9a02ed4d360ffa18c3c406ab0eb1d01ccc9c0901 |