Bug 393859

Summary: on-canvas message interferes when adding a filter mask
Product: [Applications] krita Reporter: reptillia39
Component: UsabilityAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: scottpetrovic
Priority: NOR    
Version First Reported In: 4.0.1   
Target Milestone: ---   
Platform: Other   
OS: Unspecified   
Latest Commit: https://commits.kde.org/krita/34f0c7f144d1a21df8ad39b41e3b3d68a902cc2c Version Fixed/Implemented In:
Sentry Crash Report:

Description reptillia39 2018-05-04 20:08:10 UTC 
1. Create new vector layer
2. Make a circle or whatever (probably not needed for this step, but you could so so)
3. Press the Shape Selection tool
4. Right-click, and apply filter layer/mask
5. See the message: "This tool only works on vector layer. You probably want the move tool"
6. Note that it interfere with workflows
Comment 1 Scott Petrovic 2018-05-04 20:13:23 UTC 
Just to clarify point 4, are you right-clicking the layer stack and clicking to add a filter mask to your vector layer?
Comment 2 reptillia39 2018-05-04 20:15:13 UTC 
Yes. That is what I'm doing to test this bug and describing the bug as we write to each other. Just clicking on the filter makes the message appear again, and the filter window disappear.
Comment 3 reptillia39 2018-05-04 20:19:26 UTC 
**on any filter**
Comment 4 Scott Petrovic 2018-05-04 20:20:26 UTC 
I can confirm this on my nightly build for Windows following those steps. You don't need to do point 2 with making a circle. 

The filter window appears, and then the on-canvas message pushes the filter dialog below the main krita window. This makes it appear like Krita is not responsive.
Comment 5 Halla Rempt 2018-05-10 11:42:53 UTC 
Git commit 34f0c7f144d1a21df8ad39b41e3b3d68a902cc2c by Boudewijn Rempt.
Committed on 10/05/2018 at 11:42.
Pushed by rempt into branch 'master'.

Show the default tool warning for non-vector layers on clicking

Instead of when the default tool paints.
(cherry picked from commit c8c845d1c5c5aa2085fd807fc631527e4d50f94d)

M  +9    -9    plugins/tools/defaulttool/defaulttool/DefaultTool.cpp

https://commits.kde.org/krita/34f0c7f144d1a21df8ad39b41e3b3d68a902cc2c