Bug 393845

Summary: Compositor settings opens at login
Product: [Plasma] kwin Reporter: kdesux
Component: compositingAssignee: KWin default assignee <kwin-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: subdiff
Priority: NOR Flags: mgraesslin: ReviewRequest+
Version First Reported In: 5.12.4   
Target Milestone: ---   
Platform: Arch Linux   
OS: Linux   
URL: https://phabricator.kde.org/D13235
Latest Commit: Version Fixed/Implemented In: 5.14.0
Sentry Crash Report:

Description kdesux 2018-05-04 13:47:14 UTC
Recently, the compositor settings opens on the first login after boot on one system. There is no error and the settings can be dismissed with OK or Cancel, but it is annoying to have to dismiss one more thing to get to the desktop.
Comment 1 Roman Gilg 2018-05-04 15:14:46 UTC
I noticed this as well for a short period I believe when I experimented with different mesa releases.

Please issue qdbus org.kde.KWin /KWin supportInformation
Comment 2 Martin Flöser 2018-05-04 15:19:14 UTC
There should be a warning shown in the settings dialog?
Comment 3 kdesux 2018-05-28 10:39:43 UTC
Roman, since you mention Mesa versions, this issue was on the one system using the proprietary Nvidia driver (and thus not Mesa). I have not seen the dialog recently, and it just so happens that system was recently switched to nouveau (so using Mesa now) since the legacy nvidia driver is not yet compatible with X.org server 1.20.

Martin, your reply is phrased as a statement but ends with a question mark.

Did you mean to say "There should be a warning shown in the settings dialog.", or did you mean to ask "Should there be a warning shown in the settings dialog?"

If the former, that would make sense but is not the case (no warning shown). If the latter, I don't know what the intent is, only that is seems harmless to dismiss the dialog and carry on.
Comment 4 Martin Flöser 2018-05-28 15:00:23 UTC
The intention was a statement as a question. You answered the information I wanted to know.
Comment 5 Martin Flöser 2018-05-28 15:49:01 UTC
We used to have a functionality to open the dialog with a warning. Opening the dialog is still working, showing the warning is not.
Comment 6 Martin Flöser 2018-05-31 12:06:23 UTC
Patch to remove this broken functionality at: https://phabricator.kde.org/D13235
Comment 7 Martin Flöser 2018-12-01 11:17:45 UTC
Git commit 46eceef299b56c259db111b6bb182517195599e3 by Martin Flöser.
Committed on 01/12/2018 at 10:42.
Pushed by graesslin into branch 'master'.

[opengl] Drop functionality to start kcmshell compositing

Summary:
The idea of opening the compositing kcm was to show a warning. But that
broke quite some time ago without noticing. We had two ways:
 * pass through --args command line argument
 * use dbus call to already open kcm

Neither of the two ways is working. The kwincompositing doesn't parse
the arguments and the dbus interface doesn't exist any more.

Following the advice to remove functionality nobody noticed that it is
broken, this is removed with this change. This probably broke with
introducing the new KCM which happened IIRC for Plasma 5.0.
FIXED-IN: 5.14.0

Reviewers: #kwin, #plasma

Subscribers: kwin

Tags: #kwin

Differential Revision: https://phabricator.kde.org/D13235

M  +0    -54   plugins/scenes/opengl/scene_opengl.cpp

https://commits.kde.org/kwin/46eceef299b56c259db111b6bb182517195599e3