| Summary: | Exporting query with ORDER BY crashes KEXI | ||
|---|---|---|---|
| Product: | [Applications] KEXI | Reporter: | Barrie Backhurst <barrie.backhurst> |
| Component: | Queries | Assignee: | Jarosław Staniek <staniek> |
| Status: | CLOSED FIXED | ||
| Severity: | crash | CC: | adam, albrecht.will, inksi, mrobertmdeveloper, staniek |
| Priority: | NOR | ||
| Version: | 3.1.0 | ||
| Target Milestone: | 3.2 | ||
| Platform: | Gentoo Packages | ||
| OS: | Linux | ||
| Latest Commit: | https://cgit.kde.org/kdb.git/commit/?id=3414fbddffa433b23d43376b44fef5421b734250 | Version Fixed In: | 3.2 |
| Sentry Crash Report: | |||
|
Description
Barrie Backhurst
2018-04-30 23:16:41 UTC
Thanks Barrie. The "QString::arg: Argument missing" bug will be fixed in 3.1.1. I am not sure it will fix the case you mention though. If you could attach or send me example file that crashes KEXI it could be clear. Git commit a00f37b024e1a0888de3266af9acff99e6f21aa2 by Jaroslaw Staniek. Committed on 01/05/2018 at 21:29. Pushed by staniek into branch '3.1'. Fix loading object data for given type and ID FIXED-IN:3.1.1 M +1 -1 src/KDbConnection.cpp https://commits.kde.org/kdb/a00f37b024e1a0888de3266af9acff99e6f21aa2 (In reply to Jarosław Staniek from comment #1) > Thanks Barrie. > The "QString::arg: Argument missing" bug will be fixed in 3.1.1. I am not > sure it will fix the case you mention though. If you could attach or send me > example file that crashes KEXI it could be clear. I did not want to send the whole file as is and deleted all unrelated tables(188 tables), now with the file trimmed to a minimum it no longer crashes when attempting the export, though it fails with an error message "could not open data for exporting" The command line out put is as follows QString::arg: Argument missing: SELECT o_id, o_type, o_name, o_caption, o_desc FROM kexi__objects WHERE o_type=1 AND o_id=1, 187 QString::arg: Argument missing: SELECT o_id, o_type, o_name, o_caption, o_desc FROM kexi__objects WHERE o_type=2 AND o_id=2, 187 org.kde.kdb.core: no table or query found for id== 187 I have sent you the trimmed copy via email (In reply to Jarosław Staniek from comment #2) > Git commit a00f37b024e1a0888de3266af9acff99e6f21aa2 by Jaroslaw Staniek. > Committed on 01/05/2018 at 21:29. > Pushed by staniek into branch '3.1'. > > Fix loading object data for given type and ID > > FIXED-IN:3.1.1 > > M +1 -1 src/KDbConnection.cpp > > https://commits.kde.org/kdb/a00f37b024e1a0888de3266af9acff99e6f21aa2 I have rebuilt kdb with the patch and the export works fine now Thankyou Git commit 3414fbddffa433b23d43376b44fef5421b734250 by Jaroslaw Staniek. Committed on 16/05/2018 at 08:15. Pushed by staniek into branch 'master'. Fix handling ORDER BY part of queries Summary: - new APIs - maintain relations between connections, queries and column infos - fix cloning queries with ORDER BY - update and add autotests FIXED-IN:3.2 Related: bug 392753 Test Plan: Required: KEXI & KDb 3.2 (current master) Test 1: Open report and query from https://bugs.kde.org/show_bug.cgi?id=392753#c0 in design and data views. Expected: works, no crashes Test 2: Try these on a standard Persons and Cars test: select id from cars order by owner; select id from cars order by owner, model, id; select id, model from cars order by 2, 1; Expected: works, no crash Reviewers: piggz Reviewed By: piggz Subscribers: Kexi-Devel-list Tags: #kdb Differential Revision: https://phabricator.kde.org/D12873 M +1 -1 CMakeLists.txt M +3 -0 autotests/CMakeLists.txt A +212 -0 autotests/OrderByColumnTest.cpp [License: LGPL (v2+)] A +46 -0 autotests/OrderByColumnTest.h [License: LGPL (v2+)] M +2 -2 src/KDbNativeStatementBuilder.cpp M +87 -28 src/KDbOrderByColumn.cpp M +40 -13 src/KDbOrderByColumn.h M +17 -28 src/KDbQueryColumnInfo.cpp M +25 -1 src/KDbQueryColumnInfo.h M +18 -4 src/KDbQuerySchema.cpp M +29 -1 src/KDbQuerySchema_p.h https://commits.kde.org/kdb/3414fbddffa433b23d43376b44fef5421b734250 Feel free to test the git version. *** Bug 395268 has been marked as a duplicate of this bug. *** *** Bug 402716 has been marked as a duplicate of this bug. *** Git commit d1b31bd8a6fc6632f8eeab70b5e9a0f1c8630c8f by Jaroslaw Staniek. Committed on 06/01/2019 at 21:16. Pushed by staniek into branch '3.2'. Fix handling ORDER BY part of queries Summary: - new APIs - maintain relations between connections, queries and column infos - fix cloning queries with ORDER BY - update and add autotests FIXED-IN:3.2 Related: bug 392753 Test Plan: Required: KEXI & KDb 3.2 (current master) Test 1: Open report and query from https://bugs.kde.org/show_bug.cgi?id=392753#c0 in design and data views. Expected: works, no crashes Test 2: Try these on a standard Persons and Cars test: select id from cars order by owner; select id from cars order by owner, model, id; select id, model from cars order by 2, 1; Expected: works, no crash Reviewers: piggz Reviewed By: piggz Subscribers: Kexi-Devel-list Tags: #kdb Differential Revision: https://phabricator.kde.org/D12873 M +3 -0 autotests/CMakeLists.txt A +212 -0 autotests/OrderByColumnTest.cpp [License: LGPL (v2+)] A +46 -0 autotests/OrderByColumnTest.h [License: LGPL (v2+)] M +2 -2 src/KDbNativeStatementBuilder.cpp M +87 -28 src/KDbOrderByColumn.cpp M +40 -13 src/KDbOrderByColumn.h M +17 -28 src/KDbQueryColumnInfo.cpp M +25 -1 src/KDbQueryColumnInfo.h M +18 -4 src/KDbQuerySchema.cpp M +29 -1 src/KDbQuerySchema_p.h https://commits.kde.org/kdb/d1b31bd8a6fc6632f8eeab70b5e9a0f1c8630c8f |