Bug 393453

Summary: Spacing of brush reset from 0.01 to 0.02 when overwriting it
Product: [Applications] krita Reporter: Andreas Resch <andreas>
Component: Brush enginesAssignee: Krita Bugs <krita-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: scottpetrovic
Priority: NOR    
Version First Reported In: 4.0.1   
Target Milestone: ---   
Platform: Microsoft Windows   
OS: Microsoft Windows   
Latest Commit: https://commits.kde.org/krita/a23085a0e8db4eebb86792432f49c1c6aa344203 Version Fixed/Implemented In:
Sentry Crash Report:

Description Andreas Resch 2018-04-24 07:05:12 UTC 
Hello.

The spacing of a brush is reset from 0.01 to 0.02 when overwriting it's settings. 

Here's a screencast of the issue ... http://www.andreasresch.at/upload/Krita_SpacingBug_01.zip

Cheers,
Andreas
Comment 1 Scott Petrovic 2018-05-15 13:20:02 UTC 
I can confirm this on my nightly Windows build of 4.1 (git 8a53ca7)

To reproduce, just take a brush, change its brush spacing to 0.01, then click the overwrite button.

Note that if auto-spacing is on, this bug does NOT happen
Comment 2 Scott Petrovic 2018-05-15 13:40:58 UTC 
As a further clarification, after you save to 0.01 spacing, you might have to switch to a different brush, then come back to see the spacing is set to 0.02
Comment 3 Scott Petrovic 2018-05-15 13:49:06 UTC 
After looking at the code, it is in KisBrush::setSpacing(double s)

We are not going to allow spacing to be 0.01. It destroys the performance on too many brushes it seems.

The fix for this will be to change the spacing slider so it can only go down to 0.02
Comment 4 Scott Petrovic 2018-05-16 03:19:47 UTC 
Git commit 65e24ca59b97b8f9fca6b70f967e24f8045ad101 by Scott Petrovic.
Committed on 16/05/2018 at 03:19.
Pushed by scottpetrovic into branch 'master'.
Related: bug 0, bug 02

M  +1    -1    plugins/paintops/libpaintop/kis_spacing_selection_widget.cpp

https://commits.kde.org/krita/65e24ca59b97b8f9fca6b70f967e24f8045ad101
Comment 5 Halla Rempt 2018-05-16 18:47:07 UTC 
Git commit a23085a0e8db4eebb86792432f49c1c6aa344203 by Boudewijn Rempt, on behalf of Scott Petrovic.
Committed on 16/05/2018 at 18:25.
Pushed by rempt into branch 'krita/4.0'.
Related: bug 0, bug 02

(cherry picked from commit 65e24ca59b97b8f9fca6b70f967e24f8045ad101)

M  +1    -1    plugins/paintops/libpaintop/kis_spacing_selection_widget.cpp

https://commits.kde.org/krita/a23085a0e8db4eebb86792432f49c1c6aa344203