Bug 393329

Summary:	kiosk: run_command=false unawareness in containment context
Product:	[Plasma] plasmashell	Reporter:	Harald Sitter <sitter>
Component:	Containment	Assignee:	Sebastian Kügler <sebas>
Status:	RESOLVED FIXED
Severity:	normal	CC:	kde, plasma-bugs-null
Priority:	NOR
Version First Reported In:	master
Target Milestone:	1.0
Platform:	Other
OS:	Linux
Latest Commit:	https://commits.kde.org/plasma-workspace/cfd77db90cf604e2f30afa5a0a1466cddfeeb9ac	Version Fixed/Implemented In:	5.12.5
Sentry Crash Report:

Description Harald Sitter 2018-04-20 10:34:56 UTC

in /etc/xdg/kdeglobals set

[KDE Action Restrictions][$i]
run_command=false

and relog.

This disables krunnering, and works as intended (can't get to krunner in any form or fashion).
The context menu of the desktop containment's context menu however still list the 'Run Command...' action. The action is defunct and doesn't do anything.

The action should not be visible when run_command is being disabled via an action restriction.

Comment 1 Kai Uwe Broulik 2018-04-20 11:12:46 UTC

Documentation says:

NOTE: To also disable desktop context menu run command action/run_command is required at [KDE Action Restrictions]

(which admittedly is a bit weird)

Comment 2 Kai Uwe Broulik 2018-04-23 13:14:13 UTC

Git commit cfd77db90cf604e2f30afa5a0a1466cddfeeb9ac by Kai Uwe Broulik.
Committed on 23/04/2018 at 13:13.
Pushed by broulik into branch 'Plasma/5.12'.

[ContextMenu Containment Action] Fix checking for KIOSK

Anyone else checks for run_command. Docs explicitly mention the fact that you have to also
disable action/run_command for the menu entry to appear but this is a bit awkward, isn't it.
Also fix logout to check for the correct place as listed in documentation and other code places.
FIXED-IN: 5.15.5

Differential Revision: https://phabricator.kde.org/D12376

M  +2    -2    containmentactions/contextmenu/menu.cpp

https://commits.kde.org/plasma-workspace/cfd77db90cf604e2f30afa5a0a1466cddfeeb9ac