| Summary: | getxattr takes 6 parameters in macOS | ||
|---|---|---|---|
| Product: | [Frameworks and Libraries] frameworks-kio | Reporter: | Yurii Kolesnykov <yurii.kolesnykov> |
| Component: | general | Assignee: | David Faure <faure> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kdelibs-bugs-null, nate, yurii.kolesnykov |
| Priority: | NOR | ||
| Version First Reported In: | 5.45.0 | ||
| Target Milestone: | --- | ||
| Platform: | Homebrew (macOS) | ||
| OS: | macOS | ||
| URL: | https://github.com/KDE-mac/homebrew-kde/issues/222 | ||
| Latest Commit: | https://commits.kde.org/kio/87e9e3b68fdc9b13567e40f7e02e154520bc62c4 | Version Fixed In: | 5.46 |
| Sentry Crash Report: | |||
| Attachments: | initial patch | ||
file_unix.cpp:421:19: error: no matching function for call to 'getxattr'
auto length = getxattr(filenameEncoded.data(), attrName, nullptr, 0);
^~~~~~~~
/usr/include/sys/xattr.h:61:9: note: candidate function not viable: requires 6 arguments, but 4 were provided
ssize_t getxattr(const char *path, const char *name, void *value, size_t size, u_int32_t position, int options);
^
file_unix.cpp:427:14: error: no matching function for call to 'getxattr'
length = getxattr(filenameEncoded.data(), attrName, strAttr, xattr_size);
^~~~~~~~
See commits d7cce9937d5e9af2753fadb82d11f308b58bb8fa and f1ab805c4ebcea24f0b84b785bc56515060e5eb2 Thank you very much for the patch! Please submit it using http://phabricator.kde.org/. Here is the documentation: https://community.kde.org/Infrastructure/Phabricator Git commit 87e9e3b68fdc9b13567e40f7e02e154520bc62c4 by Nathaniel Graham, on behalf of Yurii Kolesnykov. Committed on 19/04/2018 at 21:53. Pushed by ngraham into branch 'master'. getxattr takes 6 parameters in macOS Summary: Fix the xattr failure on macOS. FIXED-IN: 5.46 Reviewers: ngraham Reviewed By: ngraham Subscribers: #frameworks Tags: #frameworks Differential Revision: https://phabricator.kde.org/D12365 M +8 -0 src/ioslaves/file/file_unix.cpp M +3 -0 src/widgets/kpropertiesdialog.cpp https://commits.kde.org/kio/87e9e3b68fdc9b13567e40f7e02e154520bc62c4 |
Created attachment 112124 [details] initial patch We had written patch for kio in our homebrew tap. See attachment. It doesn't tested on other platforms.