| Summary: | Autosave stops doing its work in certain conditions | ||
|---|---|---|---|
| Product: | [Applications] krita | Reporter: | David REVOY <info> |
| Component: | File formats | Assignee: | Krita Bugs <krita-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | critical | CC: | halla, ken |
| Priority: | NOR | ||
| Version: | 4.1.0 | ||
| Target Milestone: | --- | ||
| Platform: | Microsoft Windows | ||
| OS: | Microsoft Windows | ||
| Latest Commit: | https://commits.kde.org/krita/93bc74110edbc8c9458c9cbd8ed5d1adb6c25c86 | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
David REVOY
2018-04-18 18:06:05 UTC
Further test: This bug doesn't affect Krita 4.0.0appimage ; so it's not something common to all 4.x series when "appimaged". I'll turn this bug to "Resolved" because it is fixed in Git~master and affect only 4.0.1 . I'll switch back to 4.0.0 or Git~master because having a working autosave can save my productivity in case of unexpected crash. Something similar happened to me with 4.1 just now. Krita crashed, and I lost about 45 min. of work. There was no prompt to open the autosave on restart. My Krita is set to autosave every 5 min (probably the default). I have the last .kra file at 8:26 pm. The last kra~ is at 7:45 pm, and there is no kra-autosave.kra in the document directory. This is on a Surface Book with Windows 10 64-bit. On looking at the directory with the file, I see other .kra files that I closed normally have no autosave. In fact, most do not. There are none in %temp% either. There is a krita-opengl.txt file in temp at 9:22, about the time of the crash. The contents are: ntel, Intel(R) HD Graphics 520, 3.0.0 - Build 22.20.16.4811 (Yes, the I in Intel is missing.) I am not having problems with Krita crashing. I apologize if I misunderstand Krita's autosave, but it doesn't appear to be working. All autosave files get removed if a file is saved normally. Note that there is a difference between a backup file (.kra~) which is copy of the last saved state that gets created when saving and an autosave file, which is hidden by default. Kenneth, were do you save your files? Is that an ordinary folder, or a dropbox/one drive/google driver folder? Deevad, after we closed the bug during the sprint, have you seen it again on Linux? 15:05:21 <@deevad> Ok: I could reproduce the failing autosave: it needs a first manual save (ctrl+s) that remove the autosave files. After that, no other autosave are generated with this option. I have many repetitive line in the terminal Git commit af6febcd63d92c6b840fd79abfef637e7e9bb4c7 by Dmitry Kazakov. Committed on 09/07/2018 at 14:20. Pushed by dkazakov into branch 'master'. Fix activation of the autosave timer after modify+save+modify cycle There were two problems: 1) modifiedAfterAutosave should be reset false every time we mark the image as clean. Otherwise it may keep the old value 2) modifiedAfterAutosave value should be used **only** for the autosave slot entry. For restarting the time we should ask the timer itself M +3 -9 libs/ui/KisDocument.cpp M +0 -3 libs/ui/KisDocument.h https://commits.kde.org/krita/af6febcd63d92c6b840fd79abfef637e7e9bb4c7 I've started new builds: build 56: https://binary-factory.kde.org/job/Krita_Stable_Windows_Build/ build 52: https://binary-factory.kde.org/job/Krita_Stable_Appimage_Build/ Please test them when they are done. Git commit 93bc74110edbc8c9458c9cbd8ed5d1adb6c25c86 by Boudewijn Rempt, on behalf of Dmitry Kazakov. Committed on 09/07/2018 at 14:40. Pushed by rempt into branch 'krita/4.1'. Fix activation of the autosave timer after modify+save+modify cycle There were two problems: 1) modifiedAfterAutosave should be reset false every time we mark the image as clean. Otherwise it may keep the old value 2) modifiedAfterAutosave value should be used **only** for the autosave slot entry. For restarting the time we should ask the timer itself M +3 -9 libs/ui/KisDocument.cpp M +0 -3 libs/ui/KisDocument.h https://commits.kde.org/krita/93bc74110edbc8c9458c9cbd8ed5d1adb6c25c86 Looks like it's being taken care of, but to answer your question, I am saving to Documents\Krita on the local C drive. It is my understanding the autosave files should be in %temp%, which is in the standard place under AppData. There were none there, at least for the last few days. Hopefully, these don't get destroyed when you reopen the file after a crash, as the location is something I may not remember, and it takes a little research to find the location is %temp%. Reopening the last good copy is a natural thing to do first. Thanks. Autosave files for files that already have a filename are in the same folder as the file. Thanks. That seems like a good idea. That is not what the manual says, though. It is a bit terse on the subject, as well. |