Bug 393256

Summary:	Should be ported from libnm-glib/libnm-util to libnm
Product:	[Frameworks and Libraries] frameworks-kdelibs4support	Reporter:	mbiebl
Component:	general	Assignee:	kdelibs bugs <kdelibs-bugs-null>
Status:	RESOLVED DUPLICATE
Severity:	normal
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Other
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description mbiebl 2018-04-18 14:21:56 UTC

Downstream bug report: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=862877

The libnm-glib/libnm-util libraries have been deprecated upstream in
favour of libnm.


Afaics, this is used in cmake/modules/FindNetworkManager.cmake to
decide whether to enable NetworkManager support or not and
src/solid-networkstatus/kded/networkmanagerstatus.cpp includes
NetworkManager.h for a couple of defines and the version check macro.

Please consider porting this over to libnm.
libnm provides an API similar to libnm-glib/libnm-util [1].

Since libnm-dev also provides NetworkManager.h, you probably just need
to change cmake/modules/FindNetworkManager.cmake to look for libnm
instead of NetworkManager (or libnm-util) so the include path is
properly set and changing the Build-Depends on network-manager-dev to
libnm-dev.

Since libnm was introduced in network-manager 1.0, you can also drop the
explicit version checks in networkmanagerstatus.cpp via
NM_CHECK_VERSION(0,8,992).

Regards,
Michael

[1] https://developer.gnome.org/libnm/stable/

Comment 1 mbiebl 2018-04-18 14:23:12 UTC


*** This bug has been marked as a duplicate of bug 393255 ***