| Summary: | translations are not installed | ||
|---|---|---|---|
| Product: | [Applications] rkward | Reporter: | Wolfgang Bauer <wbauer1> |
| Component: | general | Assignee: | RKWard Team <rkward-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | thomas.friedrichsmeier |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Wolfgang Bauer
2018-04-16 15:52:47 UTC
Git commit 3554b69362e37d277bbb7f55cbc401f66932fab1 by Thomas Friedrichsmeier. Committed on 16/04/2018 at 18:19. Pushed by tfry into branch 'releases/0.7.0'. Must not quote parameter, here! M +2 -2 i18n/CMakeLists.txt https://commits.kde.org/rkward/3554b69362e37d277bbb7f55cbc401f66932fab1 Ouch. Thanks for reporting.
For the record, the real culprit is the quotes I added about ${_gmoFile} one commit later in https://cgit.kde.org/rkward.git/commit/i18n/CMakeLists.txt?h=releases/0.7.0&id=68b9fba32fd510203ded51dcb73553ecad7523ba .
I'll try to upload a 0.7.0a with this fix, really soon, but I suppose you will also be able to patch this in your packaging.
(Note: Without the quotes, you get a lot of empty directories for those .mo-file s that got purged for being not complete enough. Of course still better than this...)
(In reply to Thomas Friedrichsmeier from comment #2) > For the record, the real culprit is the quotes I added about ${_gmoFile} one > commit later in > https://cgit.kde.org/rkward.git/commit/i18n/CMakeLists.txt?h=releases/0.7. > 0&id=68b9fba32fd510203ded51dcb73553ecad7523ba . That's what I tried to revert first, but it didn't help. Only removing the added IF(EXISTS ...) fixes it here. I'm not a cmake expert, but I assume the .gmo will only be created after the IF, so the INSTALL is never executed... Another possible fix may be to use execute_process() instead of add_custom_command(), I think. Git commit 2364009a4986d354541d7f083d043d5417a87a8e by Thomas Friedrichsmeier. Committed on 16/04/2018 at 19:52. Pushed by tfry into branch 'releases/0.7.0'. Revert "Avoid creating empty directories for purged translations." This reverts commit 161f8230c5fd5d947981013ef7393827441dcd25. M +5 -7 i18n/CMakeLists.txt https://commits.kde.org/rkward/2364009a4986d354541d7f083d043d5417a87a8e You are right, again. The problem turns out to be that IF(EXISTS ...) checks whether the file exists at the time that cmake is run, not at the time of make install. Which it did, when I was testing without a complete wipe of the build directory, but of course not when building from scratch. Reverting seems like the best option for now, since the only downside is a couple of empty directories in the installation. Alright, RKWard 0.7.0b packages have hit the servers, now. These simply revert the commit, as you suggested. In git master, there is a new attempt at avoiding empty directories, without breaking installation: https://cgit.kde.org/rkward.git/commit/?id=23f685bb2d1eddd1eed2b16bde079c17112f5fdd . Thanks a lot for reporting! I will try not to mess up as badly for the next release, and especially be much more careful about changes late in release phase. (In reply to Thomas Friedrichsmeier from comment #6) > Alright, RKWard 0.7.0b packages have hit the servers, now. These simply > revert the commit, as you suggested. Yes, I saw it 3 hours ago already... ;-) And I can confirm that 0.7.0b builds fine here and does install the translations. Haven't tried the new commit in master yet, but will do so later. https://cgit.kde.org/rkward.git/commit/?id=23f685bb2d1eddd1eed2b16bde079c17112f5fdd seems to work fine here. Translations are still installed, empty directories are not created anymore for the too incomplete ones. Git commit 134d592a7916e10b1ec0d2a1dbdc9c17b79e523a by Thomas Friedrichsmeier. Committed on 18/04/2018 at 08:40. Pushed by tfry into branch 'master'. Installation destination for translations was not yet correct. M +2 -2 i18n/CMakeLists.txt M +1 -1 i18n/compile_po.cmake https://commits.kde.org/rkward/134d592a7916e10b1ec0d2a1dbdc9c17b79e523a |